Improve participant flow QA safeguards#29
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
localStorageand a missing submission route.Description
app/export/submission/page.tsxthat renders the existingExportPanelso/export/submissiondoes not 404.utils/session.tsto defensively validate and normalize optional fields (participant profile, pre/post surveys, game/replay objects, revision metadata) so old/stalelocalStorageshapes yield safe defaults.normalizeParticipantProfile,normalizePreRevealSurvey,normalizePostRevealSurvey, and utility readers) to avoid unsafe property access and provide safe defaults for forms and completeness checks.components/ParticipantBackgroundForm.tsxautosave effect to use a functional state update to eliminate a stale hook dependency and reliably persistparticipantProfile.docs/MANUAL_QA_CHECKLIST.mdwith step-by-step browser checks for the full participant flow, back-navigation revision behavior, replay, stalelocalStorage, server submission, and admin exports.Testing
npm run typecheckand it completed successfully. ✅npm run lintand fixed the earlier hook warning; final lint passed with no errors. ✅npm run buildand Next.js compiled and statically generated pages successfully. ✅npm run validate:sample(Zod schema) and it succeeded. ✅Codex Task