Harden admin API security for VPS pilot#27
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/adminAuth.server.tsthat validatesAuthorization: Bearer <token>, performs constant-time SHA-256 token comparison, trims configured tokens, and refuses a missing or placeholderchange-me-before-productiontoken in production.Cache-Control: no-storeusingadminJsonResponse/withAdminNoStore, and updateapp/api/admin/*routes to use those helpers.submissionJsonResponsehelper that setsCache-Control: no-storeand switch submission success and error paths to use it inapp/api/submissions/route.ts.app/api/health/route.ts) to be dynamic, includeCache-Control: no-store, and only return non-sensitive booleans (serverSubmissionEnabled,databaseConfigured) instead of secrets likeDATABASE_URL.docs/VPS_DEPLOYMENT.md,docs/DEPLOYMENT.md) to require HTTPS, discourage query-string tokens, document the need for a strongADMIN_EXPORT_TOKEN, and include an optional Caddybasic_authexample protecting/admin*and/api/admin*.Testing
npm run typecheckand it passed with no type errors.npm run lintand it passed; a pre-existing React Hook exhaustive-deps warning incomponents/ParticipantBackgroundForm.tsxwas reported but unchanged.npm run build(Next.js production build) and it completed successfully with the same lint/type output noted above.Codex Task