Add cost visibility condition before reveal#21
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/visible-resultspage without revealing the hidden-profile mapping (to study effects on attribution and later revision).Description
CostVisibilityConditionandcostVisibilityCondition?: { condition: "no-cost-info" | "partial-cost-hint" | "full-cost-preview"; assignedAt: string }toResearchSessionandResearchExport, plus computed metric fieldscostVisibilityCondition,hadAnyCostHint, andhadStrongCostHintinComputedResearchMetricsand exports; bumped schema version tohidden-cost-game-research-schema-5.assignCostVisibilityConditioninutils/session.ts(triggered fromcomponents/ResultsTable.tsx), and persist it in local storage; existing sessions without the field remain supported.ResultsTablevia a newCostVisibilityNotecomponent: no UI change forno-cost-info, a neutral hint forpartial-cost-hint, and a stronger pre-reveal hint forfull-cost-preview(both avoid revealing profile mapping).costVisibilityConditionin the research export, updated Zodlib/researchExportSchema.tsto validate the field and the new metric fields, added CSV columns inlib/adminSubmissions.ts(top-levelcost_visibility_conditionand metric columnsmetric_cost_visibility_condition,had_any_cost_hint,had_strong_cost_hint).types/research.ts,utils/session.ts,components/ResultsTable.tsx,utils/researchMetrics.ts,lib/researchExportSchema.ts,lib/adminSubmissions.ts.Testing
npm run typecheck— passed.npm run lint— passed; reported an existing React Hook dependency warning incomponents/ParticipantBackgroundForm.tsxthat pre-existed this change.npm run build— production build succeeded and pages compiled (same existing lint warning reported).Codex Task