Add post-reveal explanation framing condition#20
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
explain-to-selforexplain-to-otherand wording can be adjusted without changing the study’s neutrality.Description
explanationFrameCondition?: { condition: "explain-to-self" | "explain-to-other"; assignedAt: string }to theResearchSessionmodel and anExplanationFrameConditionNametype intypes/research.tsand include it in exports.utils/session.tsand exposeassignExplanationFrameCondition(session)which assigns the condition once (no re-randomization) when the post-reveal survey starts.PostRevealSurveyFormto callassignExplanationFrameConditionat survey start and to show condition-specific, neutral wording for the open-text question while preserving the existing10–500character validation.explanationFrameto computed metrics, addingexplanationFrameConditionto the ZodresearchExportSchemaand CSV flattening (explanation_frame_condition), bumping the research schema version tohidden-cost-game-research-schema-4, and updating the sample export.Testing
npm run typecheckand it completed successfully.npm run lint; linting passed but reports an existingreact-hooks/exhaustive-depswarning inParticipantBackgroundForm.tsx(unchanged by this PR).npm run buildand the production build completed successfully.npm run validate:sampleto validate the sample export against the updated schema and it succeeded.Codex Task