Skip to content

Commit 50b04b9

Browse files
authored
Merge pull request #146 from SongshGeoLab/dev
fix(tracker): 🐛 Rename 'distribution' to 'samples' in AimTracker for API compatibility
2 parents e045eb0 + a387f1e commit 50b04b9

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

abses/utils/tracker/aim_tracker.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def log_agent_vars(
172172
self._run.track(numeric_series.iloc[0], name=metric_name, step=step)
173173
else:
174174
dist = Distribution(
175-
distribution=numeric_series, bin_count=self._bin_count
175+
samples=numeric_series, bin_count=self._bin_count
176176
)
177177
self._run.track(dist, name=metric_name, step=step)
178178
# Additional statistics
@@ -196,7 +196,7 @@ def log_agent_vars(
196196
else:
197197
# Multiple values, use Distribution
198198
dist = Distribution(
199-
distribution=numeric_series, bin_count=self._bin_count
199+
samples=numeric_series, bin_count=self._bin_count
200200
)
201201
self._run.track(dist, name=metric_name, step=step)
202202

@@ -258,7 +258,7 @@ def log_agent_vars(
258258
)
259259
else:
260260
dist = Distribution(
261-
distribution=numeric_series, bin_count=self._bin_count
261+
samples=numeric_series, bin_count=self._bin_count
262262
)
263263
self._run.track(dist, name=metric_name, step=step)
264264
except (TypeError, ValueError):

tests/utils/test_aim_tracker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def mock_distribution_class():
4242

4343
# Create a mock Distribution class when aim is not available
4444
# It should be callable (a class), not an instance
45-
def create_mock_distribution(distribution, bin_count=64):
45+
def create_mock_distribution(samples, bin_count=64):
4646
"""Create a mock Distribution instance."""
4747
mock_instance = MagicMock()
4848
mock_instance.bin_count = bin_count
@@ -92,7 +92,7 @@ def aim_tracker_custom_bin(mock_aim_run):
9292
dist_class = Distribution
9393
else:
9494

95-
def create_mock_distribution(distribution, bin_count=100):
95+
def create_mock_distribution(samples, bin_count=100):
9696
"""Create a mock Distribution instance with custom bin_count."""
9797
mock_instance = MagicMock()
9898
mock_instance.bin_count = bin_count

0 commit comments

Comments
 (0)