feat(proportion.independent.ci): add more solvers and algorithms#394
feat(proportion.independent.ci): add more solvers and algorithms#394Snoopy1866 wants to merge 8 commits into
Conversation
Documentation build overview
2 files changed± api/proportion/independent/ci/index.html± models/proportion/independent/ci/index.html |
There was a problem hiding this comment.
Pull Request Overview
While the PR successfully adds Newcombe-Wilson algorithms and standardizes one-sided terminology, there is a significant discrepancy between the PR's stated goals and the implementation: the farrington_manning algorithm is completely missing from the code despite being listed in the description.
Additionally, the _distance_newcombe_wilson_cc implementation is susceptible to ValueError: math domain error for certain edge cases (small sample sizes or low confidence levels). Several documentation and type-hint mismatches were also identified, particularly in the test suite and function docstrings. Although Codacy analysis indicates the code is otherwise up to standards, these issues should be addressed before merging.
About this PR
- The PR description explicitly states that the 'farrington_manning' algorithm is added, but no implementation or test cases appear in the code changes. Please either implement the missing algorithm or update the PR description to match the actual scope.
Test suggestions
- Calculate confidence interval distance using Newcombe-Wilson method for two-sided, lower one-sided, and upper one-sided types.
- Calculate confidence interval distance using Newcombe-Wilson with continuity correction for two-sided, lower one-sided, and upper one-sided types.
- Calculate confidence interval distance using Farrington-Manning method.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Calculate confidence interval distance using Farrington-Manning method.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 6 high |
🟢 Metrics 31 complexity
Metric Results Complexity 31
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
bb09eec to
d6478e6
Compare
…mbe-wilson-cc` method
for more information, see https://pre-commit.ci
023b76f to
e758463
Compare
新增下列置信区间算法:
newcombe_wilsonnewcombe_wilson_ccfarrington_manningmiettinen_nurminen