From ec3ee0d4518d94f6de52480769d463e7b083f690 Mon Sep 17 00:00:00 2001
From: Baiheng Xie <874256269@qq.com>
Date: Tue, 3 Feb 2026 11:33:54 +0800
Subject: [PATCH] fix(audit): handle session commit and rollback in service

---
 src/audit/service.py        | 3 ++-
 tests/audit/test_service.py | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/audit/service.py b/src/audit/service.py
index 07c033d..02df3d6 100644
--- a/src/audit/service.py
+++ b/src/audit/service.py
@@ -36,7 +36,6 @@ async def create_audit_log(
             extra=extra,
         )
         self.session.add(audit_log)
-        await self.session.commit()
 
 
 class AuditService:
@@ -67,7 +66,9 @@ async def log(
                 extra=extra,
                 request_id=request_id,
             )
+            await self.repository.session.commit()
         except Exception:
+            await self.repository.session.rollback()
             logger.exception("Failed to create audit log")
 
 
diff --git a/tests/audit/test_service.py b/tests/audit/test_service.py
index 3406bb5..5946a6c 100644
--- a/tests/audit/test_service.py
+++ b/tests/audit/test_service.py
@@ -34,7 +34,6 @@ async def test_create_audit_log(audit_repository, mock_session):
     )
 
     mock_session.add.assert_called_once()
-    mock_session.commit.assert_called_once()
 
 
 @pytest.mark.asyncio