diff --git a/src/audit/service.py b/src/audit/service.py index 07c033d..02df3d6 100644 --- a/src/audit/service.py +++ b/src/audit/service.py @@ -36,7 +36,6 @@ async def create_audit_log( extra=extra, ) self.session.add(audit_log) - await self.session.commit() class AuditService: @@ -67,7 +66,9 @@ async def log( extra=extra, request_id=request_id, ) + await self.repository.session.commit() except Exception: + await self.repository.session.rollback() logger.exception("Failed to create audit log") diff --git a/tests/audit/test_service.py b/tests/audit/test_service.py index 3406bb5..5946a6c 100644 --- a/tests/audit/test_service.py +++ b/tests/audit/test_service.py @@ -34,7 +34,6 @@ async def test_create_audit_log(audit_repository, mock_session): ) mock_session.add.assert_called_once() - mock_session.commit.assert_called_once() @pytest.mark.asyncio