From 2de4d3bea1f0fcbd2cff023ec45a79dd1f6ff1a1 Mon Sep 17 00:00:00 2001 From: Pablo Rey Date: Thu, 26 Mar 2026 22:30:48 +0100 Subject: [PATCH 1/4] feat(packages/sui-compiler-config): add minify parameter defaulting to false --- packages/sui-compiler-config/src/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/sui-compiler-config/src/index.js b/packages/sui-compiler-config/src/index.js index 204b465ec..d9e9af119 100644 --- a/packages/sui-compiler-config/src/index.js +++ b/packages/sui-compiler-config/src/index.js @@ -10,13 +10,13 @@ const DEFAULT_BROWSER_TARGETS = { ios: '14.5' } -const getSWCConfig = ({isModern = false, isTypeScript = false, compileToCJS = false}) => { +const getSWCConfig = ({isModern = false, isTypeScript = false, compileToCJS = false, minify = false}) => { const targets = isModern ? DEFAULT_BROWSER_TARGETS : DEFAULT_LEGACY_BROWSER_TARGETS const syntaxOptions = isTypeScript ? {syntax: 'typescript', tsx: true} : {syntax: 'ecmascript', jsx: true} const moduleOptions = compileToCJS ? {module: {type: 'commonjs'}} : {} return { - minify: true, + minify, jsc: { parser: { ...syntaxOptions, From 8f85288f954fd563425195fcd2b493b579eda4aa Mon Sep 17 00:00:00 2001 From: Pablo Rey Date: Tue, 31 Mar 2026 10:40:21 +0200 Subject: [PATCH 2/4] feat(packages/sui-bundler): not minify only on TS bundles --- packages/sui-bundler/shared/module-rules-compiler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sui-bundler/shared/module-rules-compiler.js b/packages/sui-bundler/shared/module-rules-compiler.js index f3302903f..46ff89754 100644 --- a/packages/sui-bundler/shared/module-rules-compiler.js +++ b/packages/sui-bundler/shared/module-rules-compiler.js @@ -36,7 +36,7 @@ module.exports = ({isServer = false, isDevelopment = false, supportLegacyBrowser use: [ { loader: require.resolve('swc-loader'), - options: getSWCConfig({isModern: false, isTypeScript: true}) + options: getSWCConfig({isModern: false, isTypeScript: true, minify: false}) } ] } From b7fb8206caa56c417210fb05a2a20d8223ea0a3d Mon Sep 17 00:00:00 2001 From: Pablo Rey Date: Tue, 31 Mar 2026 22:33:03 +0200 Subject: [PATCH 3/4] feat(packages/sui-bundler): do not minify magic webpack comments when ts is enabled --- packages/sui-bundler/shared/module-rules-compiler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sui-bundler/shared/module-rules-compiler.js b/packages/sui-bundler/shared/module-rules-compiler.js index 46ff89754..bbb79d6b5 100644 --- a/packages/sui-bundler/shared/module-rules-compiler.js +++ b/packages/sui-bundler/shared/module-rules-compiler.js @@ -36,7 +36,7 @@ module.exports = ({isServer = false, isDevelopment = false, supportLegacyBrowser use: [ { loader: require.resolve('swc-loader'), - options: getSWCConfig({isModern: false, isTypeScript: true, minify: false}) + options: getSWCConfig({isModern: false, isTypeScript: true, preserveComments: true}) } ] } From 5e32707dc2f606ea977e60611327a824168605ab Mon Sep 17 00:00:00 2001 From: Pablo Rey Date: Tue, 31 Mar 2026 22:33:41 +0200 Subject: [PATCH 4/4] feat(packages/sui-compiler-config): preserve comments option for webpack magic comments --- packages/sui-compiler-config/src/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/sui-compiler-config/src/index.js b/packages/sui-compiler-config/src/index.js index d9e9af119..0e5a438ac 100644 --- a/packages/sui-compiler-config/src/index.js +++ b/packages/sui-compiler-config/src/index.js @@ -10,13 +10,13 @@ const DEFAULT_BROWSER_TARGETS = { ios: '14.5' } -const getSWCConfig = ({isModern = false, isTypeScript = false, compileToCJS = false, minify = false}) => { +const getSWCConfig = ({isModern = false, isTypeScript = false, compileToCJS = false, preserveComments = false}) => { const targets = isModern ? DEFAULT_BROWSER_TARGETS : DEFAULT_LEGACY_BROWSER_TARGETS const syntaxOptions = isTypeScript ? {syntax: 'typescript', tsx: true} : {syntax: 'ecmascript', jsx: true} const moduleOptions = compileToCJS ? {module: {type: 'commonjs'}} : {} + const minifyOptions = preserveComments ? {minify: {format: {comments: 'all'}}} : {} return { - minify, jsc: { parser: { ...syntaxOptions, @@ -37,6 +37,7 @@ const getSWCConfig = ({isModern = false, isTypeScript = false, compileToCJS = fa runtime: 'automatic' } }, + ...minifyOptions, loose: true, externalHelpers: true },