Skip to content

docs: apply KM heading capitalization standards to onpremise README#115

Merged
longieirl merged 35 commits into
mainfrom
feature/km-review-onpremise-readme
Mar 9, 2026
Merged

docs: apply KM heading capitalization standards to onpremise README#115
longieirl merged 35 commits into
mainfrom
feature/km-review-onpremise-readme

Conversation

@longieirl
Copy link
Copy Markdown
Member

Apply KM Style Guide heading capitalization rules:

  • H2 sections: Title case (How It Works, Configuration Steps, etc.)
  • H3+ subsections: Sentence case (Cloud Connector configuration, Deployment prerequisites, etc.)
  • Update Table of Contents to use dashes (-) instead of asterisks (*)
  • Fix all anchor links to match updated heading structure

Changes:

  • 13 heading capitalization corrections
  • Table of Contents format standardized with dash markers
  • All internal links verified and updated

Follows KM documentation standards per docs/km-style-guide.md

Pull Request

What does this PR do?

Checklist

  • Sample tested and runs without errors
  • No sensitive data included

Apply KM Style Guide heading capitalization rules:
- H2 sections: Title case (How It Works, Configuration Steps, etc.)
- H3+ subsections: Sentence case (Cloud Connector configuration, Deployment prerequisites, etc.)
- Update Table of Contents to use dashes (-) instead of asterisks (*)
- Fix all anchor links to match updated heading structure

Changes:
- 13 heading capitalization corrections
- Table of Contents format standardized with dash markers
- All internal links verified and updated

Follows KM documentation standards per docs/km-style-guide.md
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026

🔗 Link Check Results

The link checker has completed. This is an optional check and will not block the PR.

View workflow run for details

If broken links were found, please review them at your convenience.


Last updated: Run #101 at 2026-03-06T09:01:14Z

longieirl added a commit that referenced this pull request Feb 27, 2026
This commit establishes a hybrid documentation review system combining
automated linting with AI-powered contextual analysis.

## Changes

### 1. /km-review Skill Created
- New skill at .claude/skills/km-review.md
- Applies comprehensive KM standards to documentation files
- Supports --fix flag for auto-fixes
- Supports --score-only for quick quality checks
- Supports --ai-only to skip linter (AI review only)
- Integrates with docs-linter when available

### 2. docs-linter CLI Implementation
- Complete CLI implementation in docs-linter/src/cli.js
- Commands: check, fix, validate
- Color-coded output with severity levels
- JSON output support for programmatic use
- Dry-run mode for previewing fixes

### 3. docs-linter Core Updates
- Fixed remark processor initialization
- Removed unnecessary remarkStringify dependency
- Prepared for ESM/CommonJS compatibility

## Architecture

The system provides two complementary review approaches:

**Fast Automated Review (docs-linter)**
- Rule-based checking using AST parsing
- Instant feedback on objective violations
- Safe auto-fixes for common issues
- Pre-commit hook integration ready

**Deep Contextual Review (/km-review)**
- AI-powered analysis with full context
- Understands intent and technical meaning
- Explains why issues matter
- Catches subjective quality issues

## Usage

### Quick Quality Check
/km-review misc/onpremise/README.md --score-only

### Full Review with Findings
/km-review misc/onpremise/README.md

### Review and Auto-Fix
/km-review misc/onpremise/README.md --fix

### Linter Only (when functional)
node docs-linter/src/cli.js validate misc/onpremise/README.md

## Status

- ✅ /km-review skill: Fully functional
- ✅ docs-linter CLI: Implemented
- ✅ docs-linter rules: Complete (structural, formatting, content, technical)
- ⚠️ docs-linter ESM compatibility: Needs remark ESM module fix
- ✅ Integration design: Ready for when linter is functional

## Next Steps

1. Fix remark ESM imports in docs-linter (convert to ESM or use compatible versions)
2. Add pre-commit hook to run docs-linter automatically
3. Test hybrid mode with both linter + AI review
4. Add CI/CD integration for automated checks

Related to KM documentation standards initiative and PR #115
longieirl added a commit that referenced this pull request Mar 3, 2026
This commit establishes a hybrid documentation review system combining
automated linting with AI-powered contextual analysis.

- New skill at .claude/skills/km-review.md
- Applies comprehensive KM standards to documentation files
- Supports --fix flag for auto-fixes
- Supports --score-only for quick quality checks
- Supports --ai-only to skip linter (AI review only)
- Integrates with docs-linter when available

- Complete CLI implementation in docs-linter/src/cli.js
- Commands: check, fix, validate
- Color-coded output with severity levels
- JSON output support for programmatic use
- Dry-run mode for previewing fixes

- Fixed remark processor initialization
- Removed unnecessary remarkStringify dependency
- Prepared for ESM/CommonJS compatibility

The system provides two complementary review approaches:

**Fast Automated Review (docs-linter)**
- Rule-based checking using AST parsing
- Instant feedback on objective violations
- Safe auto-fixes for common issues
- Pre-commit hook integration ready

**Deep Contextual Review (/km-review)**
- AI-powered analysis with full context
- Understands intent and technical meaning
- Explains why issues matter
- Catches subjective quality issues

/km-review misc/onpremise/README.md --score-only

/km-review misc/onpremise/README.md

/km-review misc/onpremise/README.md --fix

node docs-linter/src/cli.js validate misc/onpremise/README.md

- ✅ /km-review skill: Fully functional
- ✅ docs-linter CLI: Implemented
- ✅ docs-linter rules: Complete (structural, formatting, content, technical)
- ⚠️ docs-linter ESM compatibility: Needs remark ESM module fix
- ✅ Integration design: Ready for when linter is functional

1. Fix remark ESM imports in docs-linter (convert to ESM or use compatible versions)
2. Add pre-commit hook to run docs-linter automatically
3. Test hybrid mode with both linter + AI review
4. Add CI/CD integration for automated checks

Related to KM documentation standards initiative and PR #115
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md
Comment thread misc/onpremise/README.md
Comment thread misc/onpremise/README.md
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md
Comment thread misc/onpremise/README.md Outdated
longieirl and others added 6 commits March 9, 2026 11:34
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
@longieirl longieirl self-assigned this Mar 9, 2026
longieirl and others added 17 commits March 9, 2026 11:35
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
longieirl and others added 3 commits March 9, 2026 11:37
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
@longieirl longieirl requested a review from lfindlaysap March 9, 2026 11:38
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
longieirl and others added 7 commits March 9, 2026 13:41
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
@longieirl longieirl requested a review from lfindlaysap March 9, 2026 13:42
- Convert all list markers from * to - (preferred marker rule)
- Apply sentence case to H3+ headings (Cloud Connector configuration,
  SAP BTP destination, Deployment prerequisites, etc.)
- Remove trailing question mark from "What this test validates"
- Fix "is working" -> "works" (weak phrasing rule)
@longieirl longieirl merged commit 0b4c3e7 into main Mar 9, 2026
6 checks passed
@github-actions github-actions Bot deleted the feature/km-review-onpremise-readme branch March 9, 2026 17:31
longieirl added a commit that referenced this pull request Mar 11, 2026
This commit establishes a hybrid documentation review system combining
automated linting with AI-powered contextual analysis.

- New skill at .claude/skills/km-review.md
- Applies comprehensive KM standards to documentation files
- Supports --fix flag for auto-fixes
- Supports --score-only for quick quality checks
- Supports --ai-only to skip linter (AI review only)
- Integrates with docs-linter when available

- Complete CLI implementation in docs-linter/src/cli.js
- Commands: check, fix, validate
- Color-coded output with severity levels
- JSON output support for programmatic use
- Dry-run mode for previewing fixes

- Fixed remark processor initialization
- Removed unnecessary remarkStringify dependency
- Prepared for ESM/CommonJS compatibility

The system provides two complementary review approaches:

**Fast Automated Review (docs-linter)**
- Rule-based checking using AST parsing
- Instant feedback on objective violations
- Safe auto-fixes for common issues
- Pre-commit hook integration ready

**Deep Contextual Review (/km-review)**
- AI-powered analysis with full context
- Understands intent and technical meaning
- Explains why issues matter
- Catches subjective quality issues

/km-review misc/onpremise/README.md --score-only

/km-review misc/onpremise/README.md

/km-review misc/onpremise/README.md --fix

node docs-linter/src/cli.js validate misc/onpremise/README.md

- ✅ /km-review skill: Fully functional
- ✅ docs-linter CLI: Implemented
- ✅ docs-linter rules: Complete (structural, formatting, content, technical)
- ⚠️ docs-linter ESM compatibility: Needs remark ESM module fix
- ✅ Integration design: Ready for when linter is functional

1. Fix remark ESM imports in docs-linter (convert to ESM or use compatible versions)
2. Add pre-commit hook to run docs-linter automatically
3. Test hybrid mode with both linter + AI review
4. Add CI/CD integration for automated checks

Related to KM documentation standards initiative and PR #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants