Fix macOS build: bump OSX_MIN_VERSION and C++20 cleanup#282
Merged
Conversation
PR #278 swapped Boost filesystem for std::filesystem but did not raise the macOS deployment target. On macOS the std::filesystem symbols live in libc++.dylib and Apple only shipped them in 10.15+, so the headers mark std::filesystem::path et al. as unavailable for any target below 10.15. Two source patterns from the same migration also fail under -std=c++20. - depends/hosts/darwin.mk: raise OSX_MIN_VERSION and OSX_SDK_VERSION from 10.8 / 10.11 to 11.0. Required for std::filesystem to be callable on macOS. - src/wallet/rpcwallet.cpp: drop pwalletMain from a lambda capture list. C++20 forbids naming variables with non-automatic storage duration in a capture list; the body can reference the global directly. - src/wallet/wallet.cpp: std::random_shuffle was removed in C++17. Replace with an explicit Fisher-Yates loop that reuses GetRandInt, preserving the original RNG and shuffle semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #278 swapped Boost filesystem for std::filesystem but did not raise the macOS deployment target. On macOS the std::filesystem symbols live in libc++.dylib and Apple only shipped them in 10.15+, so the headers mark std::filesystem::path et al. as unavailable for any target below 10.15. Two source patterns from the same migration also fail under -std=c++20.
depends/hosts/darwin.mk: raise OSX_MIN_VERSION and OSX_SDK_VERSION from 10.8 / 10.11 to 11.0. Required for std::filesystem to be callable on macOS.
src/wallet/rpcwallet.cpp: drop pwalletMain from a lambda capture list. C++20 forbids naming variables with non-automatic storage duration in a capture list; the body can reference the global directly.
src/wallet/wallet.cpp: std::random_shuffle was removed in C++17. Replace with an explicit Fisher-Yates loop that reuses GetRandInt, preserving the original RNG and shuffle semantics.