You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have some changes that I'm running on a custom build for Arcane:
Disable starting / stopping of fluxbenchd based on an env var. I.e. if we're running on Arcane, let systemd manage fluxbenchd.
Bump libevent dep so fluxd will build on Ubuntu 24.04
The above is incorporated into the Arcane build already... but I would rather be installing via normal channels.
It probably makes more sense to expose the fluxbenchd control via a configuration option (which I can add)
I'm assuming it would make sense to do a separate PR and get this merged before the next release
I have some changes that I'm running on a custom build for Arcane:
Disable starting / stopping of fluxbenchd based on an env var. I.e. if we're running on Arcane, let systemd manage fluxbenchd.
Bump libevent dep so fluxd will build on Ubuntu 24.04
The above is incorporated into the Arcane build already... but I would rather be installing via normal channels. It probably makes more sense to expose the fluxbenchd control via a configuration option (which I can add)
I'm assuming it would make sense to do a separate PR and get this merged before the next release
Let me know your thoughts thanks.
yes, let's have a separate PR for that, once it's done let me know and add all of as as reviewers. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a node shutdowns ungracefully. Sometimes (not deterministically) its state can get corrupted.
This change should allow the node to save a known good state after it adds a block after an orphan.
Also remove logs that are no longer needed.