Skip to content

Write to disk on next block after tip disconnected#244

Merged
blondfrogs merged 1 commit into
masterfrom
state_fix
Apr 21, 2026
Merged

Write to disk on next block after tip disconnected#244
blondfrogs merged 1 commit into
masterfrom
state_fix

Conversation

@blondfrogs
Copy link
Copy Markdown
Member

When a node shutdowns ungracefully. Sometimes (not deterministically) its state can get corrupted.

This change should allow the node to save a known good state after it adds a block after an orphan.

Also remove logs that are no longer needed.

@MorningLightMountain713
Copy link
Copy Markdown
Contributor

I have some changes that I'm running on a custom build for Arcane:

  • Disable starting / stopping of fluxbenchd based on an env var. I.e. if we're running on Arcane, let systemd manage fluxbenchd.
  • Bump libevent dep so fluxd will build on Ubuntu 24.04

The above is incorporated into the Arcane build already... but I would rather be installing via normal channels.
It probably makes more sense to expose the fluxbenchd control via a configuration option (which I can add)

I'm assuming it would make sense to do a separate PR and get this merged before the next release

Let me know your thoughts thanks.

@Cabecinha84
Copy link
Copy Markdown
Member

I have some changes that I'm running on a custom build for Arcane:

  • Disable starting / stopping of fluxbenchd based on an env var. I.e. if we're running on Arcane, let systemd manage fluxbenchd.
  • Bump libevent dep so fluxd will build on Ubuntu 24.04

The above is incorporated into the Arcane build already... but I would rather be installing via normal channels. It probably makes more sense to expose the fluxbenchd control via a configuration option (which I can add)

I'm assuming it would make sense to do a separate PR and get this merged before the next release

Let me know your thoughts thanks.

yes, let's have a separate PR for that, once it's done let me know and add all of as as reviewers. Thank you.

Copy link
Copy Markdown
Member

@Cabecinha84 Cabecinha84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@blondfrogs blondfrogs merged commit a1ed4cd into master Apr 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants