v1.7.9#148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important enhancements and fixes to the cluster operator, focusing on improved SQL query analysis, reliability in query handling, logging robustness, and configuration correctness. It also includes minor updates to versioning and UI display.
SQL Query Analysis and Handling:
sql-query-identifierlibrary inlib/sqlAnalyzer.js, enabling more accurate parsing of multi-statement queries, especially for MariaDB. Fallback logic ensures resilience if parsing fails. [1] [2] [3]Operator.jsby adding thehandleStmtResultmethod. This ensures that write queries executed via prepared statements are properly replicated and that protocol mismatches are avoided, preventing client desynchronization. [1] [2]Reliability and Safety Improvements:
DBClient.jsto suppress raw socket writes duringchangeUseroperations, preventing protocol corruption during authentication exchanges. [1] [2]Configuration and Logging:
authMasterOnlyandsslinconfig.js, ensuring correct behavior when these values are set via environment variables.lib/log.js, preventing race conditions and potential log data loss.UI and Miscellaneous:
v1.7.9. [1] [2] [3]flux_backlogfrom the list of system databases filtered out in the UI, making it visible to users.alterstatements.Development and Dependency Updates:
mariadbandsql-query-identifieras dependencies inpackage.json. [1] [2]