-
Notifications
You must be signed in to change notification settings - Fork 4
Improve efficiency of is_smax and is_smin #19
Copy link
Copy link
Open
Labels
A-bitvecTask operating on the stevia_bitvec crate in isolation.Task operating on the stevia_bitvec crate in isolation.B-performanceA task to improve performance (regression) of some part of the code base.A task to improve performance (regression) of some part of the code base.D-easyA task that is considered to be simple to implement.A task that is considered to be simple to implement.
Description
Metadata
Metadata
Assignees
Labels
A-bitvecTask operating on the stevia_bitvec crate in isolation.Task operating on the stevia_bitvec crate in isolation.B-performanceA task to improve performance (regression) of some part of the code base.A task to improve performance (regression) of some part of the code base.D-easyA task that is considered to be simple to implement.A task that is considered to be simple to implement.
The current implementation of
Bitvec::is_smaxandBitvec::is_sminis suboptimal because there is no native implementation for it inapintand we have to emulate the logic for it instevia_bitvec. To improve this we could try implementing these (or similar) checks inapintsince they might be reasonable to add there because of the already existing constructorsunsigned_max_valueetc.