Skip to content

Geyser incompatibility #2

Description

@Camotoy

Hello! Got an error with this plugin on our support channels.

Caused by: java.lang.ClassCastException: class com.github.steveice10.packetlib.io.local.ChannelWrapper cannot be cast to class io.netty.channel.socket.SocketChannel (com.github.steveice10.packetlib.io.local.ChannelWrapper is in unnamed module of loader 'Geyser-Spigot.jar' @c83c92e; io.netty.channel.socket.SocketChannel is in unnamed module of loader 'app')
        at net.rezxis.mctp.client.netty.NettyChannelInitializer.initChannel(NettyChannelInitializer.java:16) ~[MinecraftTransport-Client-0.0.3-SNAPSHOT.jar:?]
        ... 21 more

Geyser by default now uses a separate Channel implementation that doesn't extend SocketChannel. The fix should be as simple as having the diamond parameter in https://github.com/RezxisNetwork/MinecraftTransport-Client/blob/master/src/main/java/net/rezxis/mctp/client/netty/NettyChannelInitializer.java just be Channel instead of SocketChannel. It's a change I'd recommend making anyway as eventually PaperMC/Paper#5611 may cause an issue down the line as Unix domain socket channels don't extend SocketChannel.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions