From 4f00b012ac44b91fdbaf0137bb0927dbb72a0f9e Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 16:20:58 -0500 Subject: [PATCH 1/7] Update integration test submodule to ReforgeHQ/integration-test-data MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitmodules b/.gitmodules index 8b219b2..c4cfc6d 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,3 @@ [submodule "test/shared-integration-test-data"] path = test/shared-integration-test-data - url = git@github.com:ReforgeHQ/sdk-integration-test-data.git + url = git@github.com:ReforgeHQ/integration-test-data.git From bc363ade3d18daeb818ad8694c75a2f71bcd7151 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 16:23:20 -0500 Subject: [PATCH 2/7] Update criteria evaluator to use correct virtual current-time property MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use 'reforge.current-time' instead of 'reforge-sdk.current-time' to match integration test data expectations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- lib/reforge/criteria_evaluator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reforge/criteria_evaluator.rb b/lib/reforge/criteria_evaluator.rb index bb97502..4963b5a 100644 --- a/lib/reforge/criteria_evaluator.rb +++ b/lib/reforge/criteria_evaluator.rb @@ -148,7 +148,7 @@ def value_from_properties(criterion, properties) case criterion.property_name when NAMESPACE_KEY @namespace - when 'prefab.current-time','reforge-sdk.current-time' + when 'prefab.current-time','reforge.current-time' Time.now.utc.to_i * 1000 else properties.get(criterion.property_name) From 4c40b84accd626429d2ee332140ba8e639efd383 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 16:56:52 -0500 Subject: [PATCH 3/7] Update to newest IT data --- test/shared-integration-test-data | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/shared-integration-test-data b/test/shared-integration-test-data index 9c6c558..a2d71d8 160000 --- a/test/shared-integration-test-data +++ b/test/shared-integration-test-data @@ -1 +1 @@ -Subproject commit 9c6c5589646be4cd43cca09142805d9075ca1c30 +Subproject commit a2d71d858b9ccc34efddea8fab343611bd7dab46 From cc9afcf69487c5228b6c4a303ef99b988f531fb6 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 17:00:23 -0500 Subject: [PATCH 4/7] Change the encryption key constant --- .github/workflows/ruby.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index ffde29a..d8e5913 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -43,6 +43,6 @@ jobs: run: bundle exec rake --trace env: REFORGE_INTEGRATION_TEST_SDK_KEY: ${{ secrets.REFORGE_INTEGRATION_TEST_SDK_KEY }} - PREFAB_INTEGRATION_TEST_ENCRYPTION_KEY: c87ba22d8662282abe8a0e4651327b579cb64a454ab0f4c170b45b15f049a221 + REFORGE_INTEGRATION_TEST_ENCRYPTION_KEY: c87ba22d8662282abe8a0e4651327b579cb64a454ab0f4c170b45b15f049a221 NOT_A_NUMBER: "abcd" IS_A_NUMBER: "1234" From 2233681ede51cb51c8acc3f15d43d6822617f961 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 17:07:22 -0500 Subject: [PATCH 5/7] Update messge to match expectation --- lib/reforge/errors/initialization_timeout_error.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reforge/errors/initialization_timeout_error.rb b/lib/reforge/errors/initialization_timeout_error.rb index c336504..caf67ad 100644 --- a/lib/reforge/errors/initialization_timeout_error.rb +++ b/lib/reforge/errors/initialization_timeout_error.rb @@ -4,7 +4,7 @@ module Reforge module Errors class InitializationTimeoutError < Reforge::Error def initialize(timeout_sec, key) - message = "Reforge SDK couldn't initialize in #{timeout_sec} second timeout. Trying to fetch key `#{key}`." + message = "Reforge couldn't initialize in #{timeout_sec} second timeout. Trying to fetch key `#{key}`." super(message) end end From e8416e0c43ee7a6e5d88f6e32123d143a62349e6 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 17:08:23 -0500 Subject: [PATCH 6/7] Replace prefab_api_url with reforge_api_url support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove deprecated prefab_api_url parameter from Options init - Add reforge_api_url parameter with deprecation warning - Update integration test parser to handle reforge_api_url instead of prefab_api_url - Both parameters convert to sources array for backward compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- lib/reforge/options.rb | 6 +++--- test/integration_test.rb | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/reforge/options.rb b/lib/reforge/options.rb index 92934c6..31b5650 100644 --- a/lib/reforge/options.rb +++ b/lib/reforge/options.rb @@ -51,7 +51,7 @@ module DATASOURCES sources: nil, sdk_key: ENV['SDK_API_KEY'] || ENV['PREFAB_API_KEY'], namespace: '', - prefab_api_url: nil, + reforge_api_url: nil, on_no_default: ON_NO_DEFAULT::RAISE, # options :raise, :warn_and_return_nil, initialization_timeout_sec: 10, # how long to wait before on_init_failure on_init_failure: ON_INITIALIZATION_FAILURE::RAISE, @@ -121,8 +121,8 @@ module DATASOURCES source.sub(/(belt|suspenders)\./, 'telemetry.') end[0] - if prefab_api_url - warn '[DEPRECATION] prefab_api_url is deprecated. Please provide `sources` if you need to override the default sources' + if reforge_api_url + warn '[DEPRECATION] reforge_api_url is deprecated. Please provide `sources` if you need to override the default sources' end case context_upload_mode diff --git a/test/integration_test.rb b/test/integration_test.rb index c72c972..1882cca 100644 --- a/test/integration_test.rb +++ b/test/integration_test.rb @@ -57,7 +57,7 @@ def last_post_endpoint def parse_client_overrides(overrides) Hash[ (overrides || {}).map do |(k, v)| - if k.to_s == "prefab_api_url" + if k.to_s == "reforge_api_url" [:sources, [v]] else [k.to_sym, v] From 3da3093265e54bf0983c03d1a0684857f3856f19 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Fri, 19 Sep 2025 17:16:01 -0500 Subject: [PATCH 7/7] Update it data again to get updated reforge_api_url --- test/shared-integration-test-data | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/shared-integration-test-data b/test/shared-integration-test-data index a2d71d8..1a46717 160000 --- a/test/shared-integration-test-data +++ b/test/shared-integration-test-data @@ -1 +1 @@ -Subproject commit a2d71d858b9ccc34efddea8fab343611bd7dab46 +Subproject commit 1a467175565fbdffb5808f9742ce4377f357b2d6