Skip to content

Use correct env var for integration test sdk key #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 2 commits into from
Sep 19, 2025
Merged

Use correct env var for integration test sdk key #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85259b1
use env var REFORGE_INTEGRATION_TEST_SDK_KEY instead of REFORGE_INTEG…
jkebinger Sep 18, 2025
30fe2d4
handle frozen string literal warnings
jkebinger Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Run tests
run: bundle exec rake --trace
env:
REFORGE_INTEGRATION_TEST_API_KEY: ${{ secrets.REFORGE_INTEGRATION_TEST_API_KEY }}
REFORGE_INTEGRATION_TEST_SDK_KEY: ${{ secrets.REFORGE_INTEGRATION_TEST_SDK_KEY }}
PREFAB_INTEGRATION_TEST_ENCRYPTION_KEY: c87ba22d8662282abe8a0e4651327b579cb64a454ab0f4c170b45b15f049a221
NOT_A_NUMBER: "abcd"
IS_A_NUMBER: "1234"
2 changes: 1 addition & 1 deletion test/integration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def base_client_options
prefab_config_classpath_dir: 'test',
prefab_envs: ['unit_tests'],
prefab_datasources: Reforge::Options::DATASOURCES::ALL,
sdk_key: ENV['REFORGE_INTEGRATION_TEST_API_KEY'],
sdk_key: ENV['REFORGE_INTEGRATION_TEST_SDK_KEY'],
sources: [
'https://belt.staging-prefab.cloud',
'https://suspenders.staging-prefab.cloud',
Expand Down
9 changes: 8 additions & 1 deletion test/support/common_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ def teardown
if $stderr != $oldstderr && $stderr.respond_to?(:string) && !$stderr.string.empty?
# we ignore 2.X because of the number of `instance variable @xyz not initialized` warnings
if !RUBY_VERSION.start_with?('2.')
raise "Unexpected stderr. Handle stderr with assert_stderr\n\n#{$stderr.string}"
# Filter out ld-eventsource frozen string literal warnings in Ruby 3.4+
stderr_lines = $stderr.string.split("\n").reject do |line|
line.include?('ld-eventsource') && line.include?('literal string will be frozen in the future')
end

if !stderr_lines.empty?
raise "Unexpected stderr. Handle stderr with assert_stderr\n\n#{stderr_lines.join("\n")}"
end
end
end

Expand Down
4 changes: 2 additions & 2 deletions test/test_sse_config_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def test_client
'https://belt.staging-prefab.cloud/'
]

options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_API_KEY', nil))
options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_SDK_KEY', nil))

config_loader = OpenStruct.new(highwater_mark: 4)

Expand Down Expand Up @@ -40,7 +40,7 @@ def test_failing_over
'https://api.staging-prefab.cloud/'
]

prefab_options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_API_KEY', nil))
prefab_options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_SDK_KEY', nil))

config_loader = OpenStruct.new(highwater_mark: 4)

Expand Down