From 85259b1fe468ad7e4db7a0cb235eb8b805e07b48 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Thu, 18 Sep 2025 18:17:29 -0500 Subject: [PATCH 1/2] use env var REFORGE_INTEGRATION_TEST_SDK_KEY instead of REFORGE_INTEGRATION_TEST_API_KEY --- .github/workflows/ruby.yml | 2 +- test/integration_test.rb | 2 +- test/test_sse_config_client.rb | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 94f6d24..ffde29a 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -42,7 +42,7 @@ jobs: - name: Run tests run: bundle exec rake --trace env: - REFORGE_INTEGRATION_TEST_API_KEY: ${{ secrets.REFORGE_INTEGRATION_TEST_API_KEY }} + REFORGE_INTEGRATION_TEST_SDK_KEY: ${{ secrets.REFORGE_INTEGRATION_TEST_SDK_KEY }} PREFAB_INTEGRATION_TEST_ENCRYPTION_KEY: c87ba22d8662282abe8a0e4651327b579cb64a454ab0f4c170b45b15f049a221 NOT_A_NUMBER: "abcd" IS_A_NUMBER: "1234" diff --git a/test/integration_test.rb b/test/integration_test.rb index 47d28dc..c72c972 100644 --- a/test/integration_test.rb +++ b/test/integration_test.rb @@ -134,7 +134,7 @@ def base_client_options prefab_config_classpath_dir: 'test', prefab_envs: ['unit_tests'], prefab_datasources: Reforge::Options::DATASOURCES::ALL, - sdk_key: ENV['REFORGE_INTEGRATION_TEST_API_KEY'], + sdk_key: ENV['REFORGE_INTEGRATION_TEST_SDK_KEY'], sources: [ 'https://belt.staging-prefab.cloud', 'https://suspenders.staging-prefab.cloud', diff --git a/test/test_sse_config_client.rb b/test/test_sse_config_client.rb index 51bd6a3..049000c 100644 --- a/test/test_sse_config_client.rb +++ b/test/test_sse_config_client.rb @@ -10,7 +10,7 @@ def test_client 'https://belt.staging-prefab.cloud/' ] - options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_API_KEY', nil)) + options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_SDK_KEY', nil)) config_loader = OpenStruct.new(highwater_mark: 4) @@ -40,7 +40,7 @@ def test_failing_over 'https://api.staging-prefab.cloud/' ] - prefab_options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_API_KEY', nil)) + prefab_options = Reforge::Options.new(sources: sources, sdk_key: ENV.fetch('REFORGE_INTEGRATION_TEST_SDK_KEY', nil)) config_loader = OpenStruct.new(highwater_mark: 4) From 30fe2d475c50fee7bc681573d0b0adc30494764f Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Thu, 18 Sep 2025 18:22:18 -0500 Subject: [PATCH 2/2] handle frozen string literal warnings --- test/support/common_helpers.rb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/support/common_helpers.rb b/test/support/common_helpers.rb index c46862d..23816fc 100644 --- a/test/support/common_helpers.rb +++ b/test/support/common_helpers.rb @@ -30,7 +30,14 @@ def teardown if $stderr != $oldstderr && $stderr.respond_to?(:string) && !$stderr.string.empty? # we ignore 2.X because of the number of `instance variable @xyz not initialized` warnings if !RUBY_VERSION.start_with?('2.') - raise "Unexpected stderr. Handle stderr with assert_stderr\n\n#{$stderr.string}" + # Filter out ld-eventsource frozen string literal warnings in Ruby 3.4+ + stderr_lines = $stderr.string.split("\n").reject do |line| + line.include?('ld-eventsource') && line.include?('literal string will be frozen in the future') + end + + if !stderr_lines.empty? + raise "Unexpected stderr. Handle stderr with assert_stderr\n\n#{stderr_lines.join("\n")}" + end end end