Skip to content

Commit e02ad64

Browse files
committed
Move telemetry test timeouts to shared constant, then increase from 3 to 20 seconds
1 parent 5a96b43 commit e02ad64

4 files changed

Lines changed: 10 additions & 9 deletions

File tree

sdk/src/test/java/com/reforge/sdk/integration/telemetry/ContextShapeIntegrationTestCaseDescriptor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
import com.reforge.sdk.integration.IntegrationTestFunction;
1515
import com.reforge.sdk.integration.PrefabContextFactory;
1616
import com.reforge.sdk.integration.TelemetryAccumulator;
17-
import java.time.Duration;
18-
import java.time.temporal.ChronoUnit;
1917
import java.util.List;
2018
import java.util.Map;
2119
import java.util.Optional;
@@ -88,7 +86,7 @@ protected void performVerification(Sdk sdk) {
8886
TelemetryAccumulator telemetryAccumulator = getTelemetryAccumulator(sdk);
8987

9088
await()
91-
.atMost(Duration.of(3, ChronoUnit.SECONDS))
89+
.atMost(TELEMETRY_AWAIT_TIMEOUT)
9290
.untilAsserted(() -> {
9391
List<Prefab.ContextShape> actualShapes = telemetryAccumulator
9492
.getTelemetryEventsList()

sdk/src/test/java/com/reforge/sdk/integration/telemetry/EvaluationSummaryIntegrationTestCaseDescriptor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
import com.reforge.sdk.integration.IntegrationTestClientOverrides;
2020
import com.reforge.sdk.integration.IntegrationTestFunction;
2121
import com.reforge.sdk.integration.PrefabContextFactory;
22-
import java.time.Duration;
23-
import java.time.temporal.ChronoUnit;
2422
import java.util.ArrayList;
2523
import java.util.Collections;
2624
import java.util.List;
@@ -103,7 +101,7 @@ protected void performVerification(Sdk sdk) {
103101
.collect(toImmutableMap(ExpectedDatum::getKey, Function.identity()));
104102

105103
await()
106-
.atMost(Duration.of(3, ChronoUnit.SECONDS))
104+
.atMost(TELEMETRY_AWAIT_TIMEOUT)
107105
.untilAsserted(() -> {
108106
List<Prefab.ConfigEvaluationSummary> actualSummaries = getTelemetryAccumulator(
109107
sdk

sdk/src/test/java/com/reforge/sdk/integration/telemetry/ExampleContextIntegrationTestCaseDescriptor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
import com.reforge.sdk.integration.IntegrationTestFunction;
1818
import com.reforge.sdk.integration.PrefabContextFactory;
1919
import com.reforge.sdk.integration.TelemetryAccumulator;
20-
import java.time.Duration;
21-
import java.time.temporal.ChronoUnit;
2220
import java.util.List;
2321
import java.util.Map;
2422
import java.util.Optional;
@@ -75,7 +73,7 @@ protected void performVerification(Sdk sdk) {
7573
sdk.configClient().get("my-test-key", contextSetToSend);
7674
TelemetryAccumulator telemetryAccumulator = getTelemetryAccumulator(sdk);
7775
await()
78-
.atMost(Duration.of(3, ChronoUnit.SECONDS))
76+
.atMost(TELEMETRY_AWAIT_TIMEOUT)
7977
.untilAsserted(() -> {
8078
List<Prefab.Context> actualContexts = telemetryAccumulator
8179
.getTelemetryEventsList()

sdk/src/test/java/com/reforge/sdk/integration/telemetry/TelemetryIntegrationTestCaseDescriptor.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
import com.reforge.sdk.integration.IntegrationTestCaseDescriptorIF;
1515
import com.reforge.sdk.integration.IntegrationTestClientOverrides;
1616
import com.reforge.sdk.integration.TelemetryAccumulator;
17+
import java.time.Duration;
18+
import java.time.temporal.ChronoUnit;
1719
import java.util.Optional;
1820
import java.util.stream.Collectors;
1921
import java.util.stream.StreamSupport;
@@ -28,6 +30,11 @@ public abstract class TelemetryIntegrationTestCaseDescriptor
2830
TelemetryIntegrationTestCaseDescriptor.class
2931
);
3032

33+
protected static final Duration TELEMETRY_AWAIT_TIMEOUT = Duration.of(
34+
20,
35+
ChronoUnit.SECONDS
36+
);
37+
3138
public TelemetryIntegrationTestCaseDescriptor(
3239
String name,
3340
IntegrationTestClientOverrides clientOverrides,

0 commit comments

Comments
 (0)