[release/internal/3.5.x] Fix null-ptr crash in TritonAMDGPUOptimizeDotOperands when tt.trans takes load result directly#929
Open
mstankov-amd wants to merge 1 commit into
Conversation
…akes load results directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AMD] Fix null-ptr crash in TritonAMDGPUOptimizeDotOperands when tt.trans takes load result directly
Problem
TritonAMDGPUOptimizeDotOperandscrashes withPassManager::run failedwhencompiling the flex attention backward kernel on gfx120x. The
failure is a null-pointer dereference in the
ReuseShmemForDirectAndTransposedUsepattern.
When
tt.transuses the load result directly,transOp.getSrc().getDefiningOp<ConvertLayoutOp>()returnsnullptr. The codethen passes this null
cvtOpintorewriter.modifyOpInPlace(cvtOp, ...),crashing the pass manager. There is also a latent null-dereference in the
LDBGline immediately after (debug builds only).
Fix
One-line null check: if no
ConvertLayoutOpprecedestt.trans, skip this userwith
continue. The pattern then falls through to the existingif (!transDot)guard and returns
notifyMatchFailuregracefully, leaving the IR unchanged.Ref #ROCM-1778
The file has changed in upstream/main, so this should be only 3.5 specific change. There is no failure on version 3.6