BUG: error in reading key ring

[major0]

Receiving the following error when calling client.GetAddresses(ctx):

2025/01/17 19:46:37.986534 WARN RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type, Attempt 1
2025/01/17 19:46:37.986572 ERROR RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type
Error: gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type

The user in question was returned from client.GetUser(ctx).

[major0]

I have added some log messages to Client.GetAddresses() and have narrowed this down to:

err := c.do(ctx, func(r *resty.Request) (*resty.Response, error) {
	return r.SetResult(&res).Get("/core/v4/addresses")
})

Output:

time=2025-01-18T06:29:39.114-08:00 level=DEBUG msg=GetUser
time=2025-01-18T06:29:40.139-08:00 level=DEBUG msg=GetAddresses
GetAddresses: begin
GetAddresses: before SetResult
2025/01/18 06:29:43.983821 WARN RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type, Attempt 1
2025/01/18 06:29:43.983864 ERROR RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type
GetAddresses: after SetResult, before error check
Error: gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type

[major0]

I have made the following change: major0@5f7ade6

Which now presents me with:

2025/01/18 08:50:34.946755 WARN RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type, Attempt 1
2025/01/18 08:50:34.946789 ERROR RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type
WARN[0002] Cannot unlock key KeyID="..." error="gopenpgp: the key does not contain any entity" pkg=gpa

Note: the body of the KeyID has been manually removed

[major0]

The source for the first gopenpgp error: https://github.com/ProtonMail/gopenpgp/blob/v2-proton/crypto/key.go#L425

[major0]

I have updated a local copy of https://github.com/ProtonMail/go-crypto such that it reports the mismatched type.

2025/01/18 09:43:04.100901 WARN RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type: 0x18, Attempt 1
2025/01/18 09:43:04.100929 ERROR RESTY gopenpgp: error in reading key ring: openpgp: invalid data: user ID signature with wrong type: 0x18

In this case, the type is SigTypeSubkeyBinding:

SigTypeSubkeyBinding           SignatureType = 0x18

[major0]

Okay, I have tracked this down to there being "proton-specific" releases for all of the basic tools, which is a little weird. Basically the go-proton-api is not attempting to leverage the proton branches of gopenpgp and go-crypto .. which seems .. broken.