Skip to content

♻️ #lib:living_without_playerに一括置換#1783

Merged
haiiro2gou merged 8 commits into
masterfrom
fix/lapis_living_without_player
May 17, 2026
Merged

♻️ #lib:living_without_playerに一括置換#1783
haiiro2gou merged 8 commits into
masterfrom
fix/lapis_living_without_player

Conversation

@Lapis-LJA
Copy link
Copy Markdown
Contributor

No description provided.

@haiiro2gou haiiro2gou requested a review from Copilot February 15, 2026 17:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a systematic refactoring to replace entity type selectors using type=#lib:living,type=!player with the more concise tag #lib:living_without_player throughout the codebase.

Changes:

  • Entity selector syntax standardization across object, mob, effect, and artifact files
  • Improved code readability and maintainability through consistent selector patterns

Reviewed changes

Copilot reviewed 300 out of 347 changed files in this pull request and generated no comments.

File Description
Multiple object files (1100, 1099, 1098, etc.) Updated entity selectors in hit detection and damage functions
Multiple artifact files (0001-1282) Standardized entity selectors in trigger and damage logic
Multiple effect files (0243, 0316, 0320, 0330, 0603) Updated entity selectors in tick and damage functions
Multiple mob files (0019, 0084, 0219, 0234, 0274, 0444) Replaced entity selectors in tick and attack logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@haiiro2gou haiiro2gou requested a review from Copilot May 16, 2026 20:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@haiiro2gou haiiro2gou enabled auto-merge (squash) May 16, 2026 21:01
@haiiro2gou haiiro2gou merged commit c7a16e2 into master May 17, 2026
2 checks passed
@haiiro2gou haiiro2gou deleted the fix/lapis_living_without_player branch May 17, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants