From a71cf301c9520397502c5804c56fcbb83467083a Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Wed, 18 Jun 2025 16:51:22 +0200
Subject: [PATCH 1/9] Remove failing tests for grid de-duplication

Grid de-deplication will be handled another (simpler) way in v4.
---
 tests/test_fieldset.py    | 66 ---------------------------------------
 tests/v4/test_fieldset.py | 15 +++++++++
 2 files changed, 15 insertions(+), 66 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 70624f6b0f..88687c3701 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -264,12 +264,6 @@ def test_add_field_after_pset(fieldtype):
             fieldset.add_vector_field(vfield)
 
 
-def test_fieldset_samegrids_from_file(multifile_fieldset):
-    """Test for subsetting fieldset from file using indices dict."""
-    assert multifile_fieldset.gridset.size == 1
-    assert multifile_fieldset.U.grid == multifile_fieldset.V.grid
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 @pytest.mark.parametrize("gridtype", ["A", "C"])
@@ -293,66 +287,6 @@ def assign_dataset_timestamp_dim(ds, timestamp):
     return ds
 
 
-@pytest.mark.v4remove
-@pytest.mark.xfail(reason="GH1946")
-def test_fieldset_diffgrids_from_file(tmp_path):
-    """Test for subsetting fieldset from file using indices dict."""
-    stem = "test_subsets"
-
-    timestamps = np.arange(0, 4, 1) * 86400.0
-    timestamps = np.expand_dims(timestamps, 1)
-
-    ufiles = []
-    vfiles = []
-    for index, timestamp in enumerate(timestamps):
-        # U files
-        data, dimensions = generate_fieldset_data(100, 100)
-        path = tmp_path / f"{stem}_U_{index}.nc"
-        to_xarray_dataset(data, dimensions).pipe(assign_dataset_timestamp_dim, timestamp).to_netcdf(path)
-        ufiles.append(path)
-
-        data, dimensions = generate_fieldset_data(50, 50)
-        path = tmp_path / f"{stem}_V_{index}.nc"
-        to_xarray_dataset(data, dimensions).pipe(assign_dataset_timestamp_dim, timestamp).to_netcdf(path)
-        vfiles.append(path)
-
-    files = {"U": [str(f) for f in ufiles], "V": [str(f) for f in vfiles]}
-    variables = {"U": "U", "V": "V"}
-    dimensions = {"lon": "lon", "lat": "lat", "time": "time"}
-
-    fieldset = FieldSet.from_netcdf(files, variables, dimensions, allow_time_extrapolation=True)
-    assert fieldset.gridset.size == 2
-    assert fieldset.U.grid != fieldset.V.grid
-
-
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-def test_fieldset_diffgrids_from_file_data(multifile_fieldset):
-    """Test for subsetting fieldset from file using indices dict."""
-    data, dimensions = generate_fieldset_data(100, 100)
-    field_U = FieldSet.from_data(data, dimensions).U  # TODO : Remove from_data
-    field_U.name = "B"
-
-    multifile_fieldset.add_field(field_U, "B")
-    fields = [f for f in multifile_fieldset.get_fields() if isinstance(f, Field)]
-    assert len(fields) == 3
-    assert multifile_fieldset.gridset.size == 2
-    assert multifile_fieldset.U.grid != multifile_fieldset.B.grid
-
-
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-def test_fieldset_samegrids_from_data():
-    """Test for subsetting fieldset from file using indices dict."""
-    data, dimensions = generate_fieldset_data(100, 100)
-    fieldset1 = FieldSet.from_data(data, dimensions)  # TODO : Remove from_data
-    field_data = fieldset1.U
-    field_data.name = "B"
-    fieldset1.add_field(field_data, "B")
-    assert fieldset1.gridset.size == 1
-    assert fieldset1.U.grid == fieldset1.B.grid
-
-
 def addConst(particle, fieldset, time):  # pragma: no cover
     particle.lon = particle.lon + fieldset.movewest + fieldset.moveeast
 
diff --git a/tests/v4/test_fieldset.py b/tests/v4/test_fieldset.py
index 7e317266bd..7d55274fe3 100644
--- a/tests/v4/test_fieldset.py
+++ b/tests/v4/test_fieldset.py
@@ -145,3 +145,18 @@ def test_fieldset_add_field_incompatible_calendars(fieldset):
 )
 def test_datetime_to_msg(input_, expected):
     assert _datetime_to_msg(input_) == expected
+
+
+def test_fieldset_samegrids_UV():
+    """Test that if a simple fieldset with U and V is created, that only one grid object is defined."""
+    ...
+
+
+def test_fieldset_grid_deduplication():
+    """Tests that for a full fieldset that the number of grid objects is as expected
+    (sharing of grid objects so that the particle location is not duplicated).
+
+    When grid deduplication is actually implemented, this might need to be refactored
+    into multiple tests (/more might be needed).
+    """
+    ...

From c49d6acf84d5bbe52ad520cdc1a3ed362be44763 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Wed, 18 Jun 2025 16:55:16 +0200
Subject: [PATCH 2/9] Remove failing test_add_duplicate_field from suite

Already have test_fieldset_add_field_already_exists in v4 suite.
---
 tests/test_fieldset.py | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 88687c3701..3bbf7d8d86 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -231,22 +231,6 @@ def test_add_field(xdim, ydim, tmpdir):
     assert fieldset.newfld.data.shape == fieldset.U.data.shape
 
 
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("dupobject", ["same", "new"])
-def test_add_duplicate_field(dupobject):
-    data, dimensions = generate_fieldset_data(100, 100)
-    fieldset = FieldSet.from_data(data, dimensions)  # TODO : Remove from_data
-    field = Field("newfld", fieldset.U.data, lon=fieldset.U.lon, lat=fieldset.U.lat)
-    fieldset.add_field(field)
-    with pytest.raises(RuntimeError):
-        if dupobject == "same":
-            fieldset.add_field(field)
-        elif dupobject == "new":
-            field2 = Field("newfld", np.ones((2, 2)), lon=np.array([0, 1]), lat=np.array([0, 2]))
-            fieldset.add_field(field2)
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 @pytest.mark.parametrize("fieldtype", ["normal", "vector"])

From 94add4d0dd1e29fd0e1ae893713bdb7e7ec02cb5 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Wed, 18 Jun 2025 17:00:46 +0200
Subject: [PATCH 3/9] Removing failing test_timestamps test

Originally introduced in 8639e1dc6807a14d0832b614b834ae1b314ed572 . I'm not entirely sure what it does, but I think this will be handled by the xarray data model.
---
 tests/test_fieldset.py | 32 --------------------------------
 1 file changed, 32 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 3bbf7d8d86..e2b2396ca8 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -346,38 +346,6 @@ def SampleUV2(particle, fieldset, time):  # pragma: no cover
     assert abs(pset.lat[0] - 0.5) < 1e-9
 
 
-@pytest.mark.v4remove
-@pytest.mark.xfail(reason="GH1918")
-@pytest.mark.parametrize("datetype", ["float", "datetime64"])
-def test_timestamps(datetype, tmpdir):
-    data1, dims1 = generate_fieldset_data(10, 10, 1, 10)
-    data2, dims2 = generate_fieldset_data(10, 10, 1, 4)
-    if datetype == "float":
-        dims1["time"] = np.arange(0, 10, 1) * 86400
-        dims2["time"] = np.arange(10, 14, 1) * 86400
-    else:
-        dims1["time"] = np.arange("2005-02-01", "2005-02-11", dtype="datetime64[D]")
-        dims2["time"] = np.arange("2005-02-11", "2005-02-15", dtype="datetime64[D]")
-
-    fieldset1 = FieldSet.from_data(data1, dims1)  # TODO : Remove from_data
-    fieldset1.U.data[0, :, :] = 2.0
-    fieldset1.write(tmpdir.join("file1"))
-
-    fieldset2 = FieldSet.from_data(data2, dims2)  # TODO : Remove from_data
-    fieldset2.U.data[0, :, :] = 0.0
-    fieldset2.write(tmpdir.join("file2"))
-
-    fieldset3 = FieldSet.from_parcels(tmpdir.join("file*"))
-    timestamps = [dims1["time"], dims2["time"]]
-    fieldset4 = FieldSet.from_parcels(tmpdir.join("file*"), timestamps=timestamps)
-    assert np.allclose(fieldset3.U.grid.time_full, fieldset4.U.grid.time_full)
-
-    for d in [0, 8, 10, 12]:
-        fieldset3.computeTimeChunk(d * 86400.0, 1.0)
-        fieldset4.computeTimeChunk(d * 86400.0, 1.0)
-        assert np.allclose(fieldset3.U.data, fieldset4.U.data)
-
-
 @pytest.mark.v4remove
 @pytest.mark.xfail(reason="time_periodic removed in v4")
 @pytest.mark.parametrize("use_xarray", [True, False])

From 010a6251bcd314295c74d49e824ad40f86fadd23 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:15:12 +0200
Subject: [PATCH 4/9] Remove v3 test_fieldset_from_xarray

Already handled natively
---
 tests/test_fieldset.py | 44 ------------------------------------------
 1 file changed, 44 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index e2b2396ca8..9a7e9b8c7d 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -437,50 +437,6 @@ def sampleTemp(particle, fieldset, time):  # pragma: no cover
     assert np.allclose(pset.d[0], 1.0)
 
 
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("tdim", [10, None])
-def test_fieldset_from_xarray(tdim):
-    def generate_dataset(xdim, ydim, zdim=1, tdim=1):
-        lon = np.linspace(0.0, 12, xdim, dtype=np.float32)
-        lat = np.linspace(0.0, 12, ydim, dtype=np.float32)
-        depth = np.linspace(0.0, 20.0, zdim, dtype=np.float32)
-        if tdim:
-            time = np.linspace(0.0, 10, tdim, dtype=np.float64)
-            Uxr = np.ones((tdim, zdim, ydim, xdim), dtype=np.float32)
-            Vxr = np.ones((tdim, zdim, ydim, xdim), dtype=np.float32)
-            for t in range(Uxr.shape[0]):
-                Uxr[t, :, :, :] = t / 10.0
-            coords = {"lat": lat, "lon": lon, "depth": depth, "time": time}
-            dims = ("time", "depth", "lat", "lon")
-        else:
-            Uxr = np.ones((zdim, ydim, xdim), dtype=np.float32)
-            Vxr = np.ones((zdim, ydim, xdim), dtype=np.float32)
-            for z in range(Uxr.shape[0]):
-                Uxr[z, :, :] = z / 2.0
-            coords = {"lat": lat, "lon": lon, "depth": depth}
-            dims = ("depth", "lat", "lon")
-        return xr.Dataset(
-            {"Uxr": xr.DataArray(Uxr, coords=coords, dims=dims), "Vxr": xr.DataArray(Vxr, coords=coords, dims=dims)}
-        )
-
-    ds = generate_dataset(3, 3, 2, tdim)
-    variables = {"U": "Uxr", "V": "Vxr"}
-    if tdim:
-        dimensions = {"lat": "lat", "lon": "lon", "depth": "depth", "time": "time"}
-    else:
-        dimensions = {"lat": "lat", "lon": "lon", "depth": "depth"}
-    fieldset = FieldSet.from_xarray_dataset(ds, variables, dimensions, mesh="flat")
-
-    pset = ParticleSet(fieldset, Particle, 0, 0, depth=20)
-
-    pset.execute(AdvectionRK4, dt=1, runtime=10)
-    if tdim == 10:
-        assert np.allclose(pset.lon_nextloop[0], 4.5) and np.allclose(pset.lat_nextloop[0], 10)
-    else:
-        assert np.allclose(pset.lon_nextloop[0], 5.0) and np.allclose(pset.lat_nextloop[0], 10)
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="From_pop is not supported during v4-alpha development. This will be reconsidered in v4.")
 def test_fieldset_frompop():

From 9620eb2c38eafde2d0f0c08da6285437a3f69b99 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:18:24 +0200
Subject: [PATCH 5/9] Move test_fieldset_frompop

---
 tests/test_fieldset.py          | 12 ------------
 tests/v4/test_structured_gcm.py | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 12 deletions(-)
 create mode 100644 tests/v4/test_structured_gcm.py

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 9a7e9b8c7d..5642b5ba07 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -437,18 +437,6 @@ def sampleTemp(particle, fieldset, time):  # pragma: no cover
     assert np.allclose(pset.d[0], 1.0)
 
 
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="From_pop is not supported during v4-alpha development. This will be reconsidered in v4.")
-def test_fieldset_frompop():
-    filenames = str(TEST_DATA / "POPtestdata_time.nc")
-    variables = {"U": "U", "V": "V", "W": "W", "T": "T"}
-    dimensions = {"lon": "lon", "lat": "lat", "time": "time"}
-
-    fieldset = FieldSet.from_pop(filenames, variables, dimensions, mesh="flat")
-    pset = ParticleSet.from_list(fieldset, Particle, lon=[3, 5, 1], lat=[3, 5, 1])
-    pset.execute(AdvectionRK4, runtime=3, dt=1)
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 def test_fieldset_from_data_gridtypes():
diff --git a/tests/v4/test_structured_gcm.py b/tests/v4/test_structured_gcm.py
new file mode 100644
index 0000000000..fa8eee40a8
--- /dev/null
+++ b/tests/v4/test_structured_gcm.py
@@ -0,0 +1,17 @@
+"""Tests for outputs from structured GCMs."""
+
+import pytest
+
+
+@pytest.mark.v4alpha
+@pytest.mark.skip(reason="From_pop is not supported during v4-alpha development. This will be reconsidered in v4.")
+def test_fieldset_frompop():
+    # # Initial v3 test
+    # filenames = str(TEST_DATA / "POPtestdata_time.nc")
+    # variables = {"U": "U", "V": "V", "W": "W", "T": "T"}
+    # dimensions = {"lon": "lon", "lat": "lat", "time": "time"}
+
+    # fieldset = FieldSet.from_pop(filenames, variables, dimensions, mesh="flat")
+    # pset = ParticleSet.from_list(fieldset, Particle, lon=[3, 5, 1], lat=[3, 5, 1])
+    # pset.execute(AdvectionRK4, runtime=3, dt=1)
+    pass

From 9a40371ead3337347eb38a350718581a2a7b6a42 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:29:52 +0200
Subject: [PATCH 6/9] Remove v3 tests made irrelevant by new internals

Now that we rely on xarray internally:
- test_fieldset_from_data_timedims (origin is 0f4de2c5226d302abc39a42e8d2b08671a93a419)
- test_fieldset_from_data_different_dimensions (origin is c6eb80445da97e57342bfbc183233aa4ac618415)
---
 tests/test_fieldset.py | 49 +-----------------------------------------
 1 file changed, 1 insertion(+), 48 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 5642b5ba07..8f5a392298 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -79,53 +79,6 @@ def multifile_fieldset(tmp_path):
     return FieldSet.from_netcdf(files, variables, dimensions)
 
 
-@pytest.mark.v4remove
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("ttype", ["float", "datetime64"])
-@pytest.mark.parametrize("tdim", [1, 20])
-def test_fieldset_from_data_timedims(ttype, tdim):
-    data, dimensions = generate_fieldset_data(10, 10, tdim=tdim)
-    if ttype == "float":
-        dimensions["time"] = np.linspace(0, 5, tdim)
-    else:
-        dimensions["time"] = [np.datetime64("2018-01-01") + np.timedelta64(t, "D") for t in range(tdim)]
-    fieldset = FieldSet.from_data(data, dimensions)
-    for i, dtime in enumerate(dimensions["time"]):
-        print(fieldset.U, dtime)
-        assert fieldset.U.time[i].data == dtime
-
-
-@pytest.mark.v4remove
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("xdim", [100, 200])
-@pytest.mark.parametrize("ydim", [100, 50])
-def test_fieldset_from_data_different_dimensions(xdim, ydim):
-    """Test for fieldset initialisation from data using dict-of-dict for dimensions."""
-    zdim, tdim = 4, 2
-    lon = np.linspace(0.0, 1.0, xdim, dtype=np.float32)
-    lat = np.linspace(0.0, 1.0, ydim, dtype=np.float32)
-    depth = np.zeros(zdim, dtype=np.float32)
-    time = np.zeros(tdim, dtype=np.float64)
-    U = np.zeros((ydim, xdim), dtype=np.float32)
-    V = np.ones((ydim, xdim), dtype=np.float32)
-    P = 2 * np.ones((tdim, zdim, int(ydim / 2), int(xdim / 2)), dtype=np.float32)
-    data = {"U": U, "V": V, "P": P}
-    dimensions = {
-        "U": {"lat": lat, "lon": lon},
-        "V": {"lat": lat, "lon": lon},
-        "P": {"lat": lat[0::2], "lon": lon[0::2], "depth": depth, "time": time},
-    }
-
-    fieldset = FieldSet.from_data(data, dimensions)
-    assert len(fieldset.U.data.shape) == 4
-    assert len(fieldset.V.data.shape) == 4
-    assert len(fieldset.P.data.shape) == 4
-    assert fieldset.P.data.shape == (tdim, zdim, ydim / 2, xdim / 2)
-    assert np.allclose(fieldset.U.data, 0.0, rtol=1e-12)
-    assert np.allclose(fieldset.V.data, 1.0, rtol=1e-12)
-    assert np.allclose(fieldset.P.data, 2.0, rtol=1e-12)
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 def test_fieldset_from_modulefile():
@@ -317,7 +270,7 @@ def test_vector_fields(swapUV):
 
 
 @pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
+@pytest.mark.xfail(reason="GH1946, originated in GH938")
 def test_add_second_vector_field():
     lon = np.linspace(0.0, 10.0, 12, dtype=np.float32)
     lat = np.linspace(0.0, 10.0, 10, dtype=np.float32)

From 717309bc1ff35db51727d69dd73395ac35cae014 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:31:51 +0200
Subject: [PATCH 7/9] Move test_add_field_after_pset

---
 tests/test_fieldset.py    | 17 -----------------
 tests/v4/test_fieldset.py |  5 +++++
 2 files changed, 5 insertions(+), 17 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 8f5a392298..894398f03f 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -184,23 +184,6 @@ def test_add_field(xdim, ydim, tmpdir):
     assert fieldset.newfld.data.shape == fieldset.U.data.shape
 
 
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("fieldtype", ["normal", "vector"])
-def test_add_field_after_pset(fieldtype):
-    data, dimensions = generate_fieldset_data(100, 100)
-    fieldset = FieldSet.from_data(data, dimensions)  # TODO : Remove from_data
-    pset = ParticleSet(fieldset, Particle, lon=0, lat=0)  # noqa ; to trigger fieldset._check_complete
-    field1 = Field("field1", fieldset.U.data, lon=fieldset.U.lon, lat=fieldset.U.lat)
-    field2 = Field("field2", fieldset.U.data, lon=fieldset.U.lon, lat=fieldset.U.lat)
-    vfield = VectorField("vfield", field1, field2)
-    with pytest.raises(RuntimeError):
-        if fieldtype == "normal":
-            fieldset.add_field(field1)
-        elif fieldtype == "vector":
-            fieldset.add_vector_field(vfield)
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 @pytest.mark.parametrize("gridtype", ["A", "C"])
diff --git a/tests/v4/test_fieldset.py b/tests/v4/test_fieldset.py
index 7d55274fe3..99cc54e432 100644
--- a/tests/v4/test_fieldset.py
+++ b/tests/v4/test_fieldset.py
@@ -160,3 +160,8 @@ def test_fieldset_grid_deduplication():
     into multiple tests (/more might be needed).
     """
     ...
+
+
+def test_fieldset_add_field_after_pset():
+    # ? Should it be allowed to add fields (normal or vector) after a ParticleSet has been initialized?
+    ...

From 9a3a01e898c262f5d48ea32a2edacdc511ef191c Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:35:35 +0200
Subject: [PATCH 8/9] Remove v3 test_add_field

Already in v4 test suite
---
 tests/test_fieldset.py | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/tests/test_fieldset.py b/tests/test_fieldset.py
index 894398f03f..b1fbbf56b6 100644
--- a/tests/test_fieldset.py
+++ b/tests/test_fieldset.py
@@ -12,7 +12,7 @@
     ParticleSet,
     Variable,
 )
-from parcels.field import Field, VectorField
+from parcels.field import VectorField
 from parcels.tools.converters import GeographicPolar, UnitConverter
 from tests.utils import TEST_DATA
 
@@ -172,18 +172,6 @@ def test_illegal_dimensionsdict(calltype):
             FieldSet.from_nemo(filenames, variables, dimensions)
 
 
-@pytest.mark.v4alpha
-@pytest.mark.xfail(reason="GH1946")
-@pytest.mark.parametrize("xdim", [100, 200])
-@pytest.mark.parametrize("ydim", [100, 200])
-def test_add_field(xdim, ydim, tmpdir):
-    data, dimensions = generate_fieldset_data(xdim, ydim)
-    fieldset = FieldSet.from_data(data, dimensions)  # TODO : Remove from_data
-    field = Field("newfld", fieldset.U.data, lon=fieldset.U.lon, lat=fieldset.U.lat)
-    fieldset.add_field(field)
-    assert fieldset.newfld.data.shape == fieldset.U.data.shape
-
-
 @pytest.mark.v4alpha
 @pytest.mark.xfail(reason="GH1946")
 @pytest.mark.parametrize("gridtype", ["A", "C"])

From d8de3ae9da7e401093c1060a419233272593a146 Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Thu, 19 Jun 2025 12:40:34 +0200
Subject: [PATCH 9/9] Remove v3 test_fieldset_warning_timestamps

Not relevant now due to xarray data model
---
 tests/tools/test_warnings.py | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/tests/tools/test_warnings.py b/tests/tools/test_warnings.py
index 74dbe8b40d..49007b6717 100644
--- a/tests/tools/test_warnings.py
+++ b/tests/tools/test_warnings.py
@@ -25,19 +25,6 @@ def test_fieldset_warning_pop():
         FieldSet.from_pop(filenames, variables, dimensions, mesh="flat")
 
 
-@pytest.mark.v4remove
-@pytest.mark.xfail(reason="Incorrect warning message being raised (and GH1918)")
-def test_fieldset_warning_timestamps():
-    filenames = str(TEST_DATA / "POPtestdata_time.nc")
-    variables = {"U": "U", "V": "V", "W": "W", "T": "T"}
-    dimensions = {"lon": "lon", "lat": "lat", "depth": "w_deps", "time": "time"}
-    with pytest.warns(
-        FieldSetWarning, match="something"
-    ):  # TODO: Fix warning message. Shouldn't be "General s-levels are not supported"
-        # timestamps with time in file warning
-        FieldSet.from_pop(filenames, variables, dimensions, mesh="flat", timestamps=[0, 1, 2, 3])
-
-
 def test_file_warnings(tmp_zarrfile):
     fieldset = FieldSet.from_data(
         data={"U": np.zeros((1, 1)), "V": np.zeros((1, 1))}, dimensions={"lon": [0], "lat": [0]}