From a8ce779ce4d50e2b0f0bed3783f62636385e252d Mon Sep 17 00:00:00 2001 From: Diamondback88 <23108617+Diamondback88@users.noreply.github.com> Date: Fri, 28 Mar 2025 17:31:53 -0400 Subject: [PATCH 1/2] Make random variable initialized only once --- .../java/parallelmc/parallelutils/util/RandomTools.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java b/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java index d8ea81ef..272bf7ab 100644 --- a/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java +++ b/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java @@ -7,6 +7,12 @@ */ public class RandomTools { + private static Random r; + + private RandomTools() { + r = new Random(); + } + /** * Calculates a random integer between two integer values * @param low The first integer @@ -14,7 +20,6 @@ public class RandomTools { * @return The random integer between low and high, inclusive */ public static int betweenTwoNumbers(int low, int high) { - Random r = new Random(); return r.nextInt(high - low + 1) + low; } } From ce936af68b4556b37bc0fb4f75f38aa3d6531304 Mon Sep 17 00:00:00 2001 From: Diamondback88 <23108617+Diamondback88@users.noreply.github.com> Date: Fri, 28 Mar 2025 17:34:15 -0400 Subject: [PATCH 2/2] Fix --- .../java/parallelmc/parallelutils/util/RandomTools.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java b/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java index 272bf7ab..13d04b8f 100644 --- a/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java +++ b/api/src/main/java/parallelmc/parallelutils/util/RandomTools.java @@ -7,11 +7,7 @@ */ public class RandomTools { - private static Random r; - - private RandomTools() { - r = new Random(); - } + private static final Random r = new Random(); /** * Calculates a random integer between two integer values