Added mocking tests for Server start() and common fail on bind().

Author: PLCodingStuff

.gitignore

@@ -140,6 +140,3 @@ $RECYCLE.BIN/
 .DS_Store
 
 _NCrunch*
-
-# Temporarily
-tests/test_network.py

Network/server.py

@@ -1,7 +1,6 @@
 from socket import (
     SOL_SOCKET,
     SO_REUSEADDR,
-    error as sockerror,
     SHUT_RDWR,
     socket,
 )
@@ -58,24 +57,19 @@ def start(self) -> None:
             self._socket.listen(1)
             print(f"Server listening on {self._host}:{self._port}")
 
-        except sockerror as e:
-            if e.errno != 10038:
-                print(f"Error in server: {e}")
+        except OSError as e:
             self._socket.close()
             self._socket = None
-            self._conn.update_state()
-            return
+            raise e
 
         try:
             self.conn_s, addr = self._socket.accept()
             print(f"{str(addr)} connected")
-        except sockerror as e:
-            if e.errno != 10038:
-                print(f"Error in server {e}")
+        except OSError as e:
             self._socket.close()
             self._socket = None
             self._conn.update_state()
-            return
+            raise e
 
     def start_and_handle(self):
         self.start()
@@ -129,7 +123,7 @@ def handler(self) -> None:
                     self._conn.update_state()
                     print("Press Enter to exit")
                     break
-        except sockerror as e:
+        except OSError as e:
             print(str(e))
             self.close()
 
@@ -142,7 +136,7 @@ def close(self) -> None:
         if self.conn_s:
             try:
                 self.conn_s.shutdown(SHUT_RDWR)
-            except sockerror as e:
+            except OSError as e:
                 # This error is due to lack of connection, so
                 # `shutdown()` cannot be called without one.
                 if e.errno != 10038:
@@ -152,4 +146,4 @@ def close(self) -> None:
             self.conn_s = None
         if self._socket:
             self._socket.close()
-            self._socket = None
+            self._socket = None

tests/test_network.py

@@ -0,0 +1,43 @@
+import unittest
+from unittest.mock import patch
+from Network import Server, Connection
+from socket import socket, AF_INET, SOCK_STREAM
+import errno
+
+
+class TestServer(unittest.TestCase):
+    @patch("socket.socket.accept")
+    def test_start_successful(self, mock_accept):
+        conn_s = socket(AF_INET, SOCK_STREAM)
+        mock_accept.return_value = (conn_s, "127.0.0.1")
+
+        conn: Connection = Connection()
+        server: Server = Server("127.0.0.1", 6000, conn)
+
+        server.start()
+
+        self.assertEqual(server.conn_s, conn_s)
+        server.close()
+
+    @patch("socket.socket.bind", side_effect=OSError(errno.EADDRINUSE))
+    def test_start_fail_bind_eaddrinuse(self, mock_bind):
+        with self.assertRaises(OSError) as context:
+            conn: Connection = Connection()
+            server: Server = Server("127.0.0.1", 6000, conn)
+
+            server.start()
+
+        self.assertEqual(str(context.exception), str(errno.EADDRINUSE))
+
+    @patch("socket.socket.bind", side_effect=OSError(errno.EACCES))
+    def test_start_fail_bind_eaccess(self, mock_bind):
+        with self.assertRaises(OSError) as context:
+            conn: Connection = Connection()
+            server: Server = Server("127.0.0.1", 6000, conn)
+
+            server.start()
+
+        self.assertEqual(str(context.exception), str(errno.EACCES))
+
+if __name__ == "__main__":
+    unittest.main()