esphome/AsyncTCP-esphome @ ^2.1.0 does NOT compile

[homonto]

Compiling .pio/build/box42/lib962/ESPAsyncWebServer-esphome/AsyncEventSource.cpp.o
.pio/libdeps/box42/AsyncTCP-esphome/src/AsyncTCP.cpp:753:2: error: #else without #if
 #else
  ^~~~
.pio/libdeps/box42/AsyncTCP-esphome/src/AsyncTCP.cpp:755:2: error: #endif without #if
 #endif
  ^~~~~
.pio/libdeps/box42/AsyncTCP-esphome/src/AsyncTCP.cpp:1020: error: unterminated #if
 #if LWIP_IPV4 && LWIP_IPV6

here:

bool AsyncClient::connect(const char* host, uint16_t port){
    ip_addr_t addr;

    if(!_start_async_task()){
      log_e("failed to start task");
      return false;
    }

    err_t err = dns_gethostbyname(host, &addr, (dns_found_callback)&_tcp_dns_found, this);
    if(err == ERR_OK) {
        if(addr.type == IPADDR_TYPE_V6) {
            return connect(IPv6Address(addr.u_addr.ip6.addr), port);
        }
        return connect(IPAddress(addr.u_addr.ip4.addr), port);
#else
        return connect(IPAddress(addr.addr), port);
#endif
    } else if(err == ERR_INPROGRESS) {
        _connect_port = port;
        return true;
    }
    log_e("error: %d", err);
    return false;
}

[LouDou]

Yup, this and the other libraries depending (e.g. ottowinter/ESPAsyncWebServer-esphome) on this are currently completely broken.

Given the libs that use this also do not specify which versions they depend on, the build system just goes and grabs the highest available version. Therefore, it is impossible as a user of ESPAsyncWebServer to pin an earlier version and have a working build.

It's pretty poor form to a) commit code that doesn't build but then also b) push it and c) version it and release it for use and d) have other libraries depend only on the latest version of it.

[homonto]

this works for me for my project (platformio.ini):

    ottowinter/ESPAsyncTCP-esphome @ ^1.2.3
    esphome/ESPAsyncWebServer-esphome@^2.1.0
    ; fixed to 2.0.0 as newer does not compile
    esphome/AsyncTCP-esphome@2.0.0

[mpboddie]

I can't see any reasoning for why this would have been committed and released. From looking at the code changes I can't see any justification for getting rid of the entire if else block in the area of line 753 or the one at 1020, therefor I would imagine that it was a mistake that the if line should be added back to 749 and the else block back to 1024-1026. Doing so locally fixes the build issues.