Skip to content

The Angular Quadratures' regression tests are not consistent. #915

Description

@AndrewNJ03

This does directly impact the current PR to add new angular quadrature classes into OpenSn, but I noticed while adding the 2D variants that there is no "standard" across the regression suite for the angular tests found in /test/python/framework/math/quadrature.

For example, lebedev_quad_3d_xyz.py and sldfesq_test.py just check the weight sum, whereas prod_quad_1d_slab.py, prod_quad_2d_xy.py, and prod_quad_3d_xyz.py generate a prescribed quadrature and compare it against a preset.

PR #899 expands this, with lebedev_quad_2d_xy.py copying the Lebedev/SLDFES style. triangular_quad_2d_xy.py and triangular_quad_3d_xyz.py copy the Product style, but compare X, Y, Z, and W instead of Theta, Phi, and W.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions