You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following issues need to be addresses as part of the refactoring of LBSSolver:
Current solver classes (LBSSolver, DiscreteOrdinatesSolver, DiffusionDFEMSolver, DiscreteOrdinatesCurvilinearSolver) should be promoted to problems (LBSProblem, DiscreteOrdinatesProblem, etc.). It may make sense to split the base Solver class into separate Solver and Problem classes with field functions as members of the problem class. Classes now located in modules/linear_boltzmann_solvers/executors should be renamed solvers (LBSSteadyStateSolver, NonLinearKEigenSolver, PIKEigenSolver, etc.).
Convert flux moment vectors to std::vector<std::vector<>> to eliminate complex copy operations (LBSVecOps)
Use std::swap where appropriate to prevent copying of flux moments, etc.
The following issues need to be addresses as part of the refactoring of LBSSolver:
LBSSolver,DiscreteOrdinatesSolver,DiffusionDFEMSolver,DiscreteOrdinatesCurvilinearSolver) should be promoted to problems (LBSProblem,DiscreteOrdinatesProblem, etc.). It may make sense to split the baseSolverclass into separateSolverandProblemclasses with field functions as members of the problem class. Classes now located inmodules/linear_boltzmann_solvers/executorsshould be renamed solvers (LBSSteadyStateSolver,NonLinearKEigenSolver,PIKEigenSolver, etc.).std::vector<std::vector<>>to eliminate complex copy operations (LBSVecOps)std::swapwhere appropriate to prevent copying of flux moments, etc.lbs_solverblock in the input, not thelbs_optionsblock. Boundary conditions are addressed by Adding boundary conditions as an optional solver input parameter #723, Add set/clear sources and boundary conditions methods to Python interface #745, Adding volumetric and point sources as optional input parameters for LBSProblem #748, Removing extraneous boundary processing from SetOptions #765.