seq_cutoff: Split seq cutoff and seq detect

Move sequence detection functionality into a separate component
that can be used by subsystems other than sequential cutoff.

Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>

Author: robertbaldyga

inc/ocf_core.h

@@ -1,6 +1,7 @@
 /*
  * Copyright(c) 2012-2022 Intel Corporation
  * Copyright(c) 2024 Huawei Technologies
+ * Copyright(c) 2026 Unvertical
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
@@ -111,23 +112,22 @@ uint32_t ocf_core_get_seq_cutoff_threshold(ocf_core_t core);
 ocf_seq_cutoff_policy ocf_core_get_seq_cutoff_policy(ocf_core_t core);
 
 /**
- * @brief Get sequential cutoff stream promotion req count of given core object
+ * @brief Get sequence detector stream promotion request count
  *
  * @param[in] core Core object
  *
- * @retval Sequential cutoff stream promotion request count
+ * @retval Sequence detector stream promotion request count
  */
-uint32_t ocf_core_get_seq_cutoff_promotion_count(ocf_core_t core);
+uint32_t ocf_core_get_seq_detect_promotion_count(ocf_core_t core);
 
 /**
- * @brief Whether to promote sequential cutoff stream
- * to global structures when threshold is reached
+ * @brief Get sequence detector stream promotion threshold (in bytes)
  *
  * @param[in] core Core object
  *
- * @retval Sequential cutoff stream promote_on_threshold switch value
+ * @retval Sequence detector stream promotion threshold [B]
  */
-bool ocf_core_get_seq_cutoff_promote_on_threshold(ocf_core_t core);
+uint32_t ocf_core_get_seq_detect_promotion_threshold(ocf_core_t core);
 
 /**
  * @brief Get name of given core object

inc/ocf_debug.h

@@ -1,23 +1,24 @@
 /*
  * Copyright(c) 2012-2021 Intel Corporation
  * Copyright(c) 2024 Huawei Technologies
+ * Copyright(c) 2026 Unvertical
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef __OCF_DEBUG_H__
 #define __OCF_DEBUG_H__
 
-struct ocf_dbg_seq_cutoff_status {
+struct ocf_dbg_seq_detect_status {
 	struct {
 		uint64_t last;
 		uint64_t bytes;
 		uint32_t rw : 1;
 		uint32_t active : 1;
-	} streams[OCF_SEQ_CUTOFF_PERCORE_STREAMS];
+	} streams[OCF_SEQ_DETECT_PERCORE_STREAMS];
 };
 
-void ocf_dbg_get_seq_cutoff_status(ocf_core_t core,
-		struct ocf_dbg_seq_cutoff_status *status);
+void ocf_dbg_get_seq_detect_status(ocf_core_t core,
+		struct ocf_dbg_seq_detect_status *status);
 
 bool ocf_dbg_cache_is_settled(ocf_cache_t cache);
 

inc/ocf_def.h

@@ -231,12 +231,12 @@ typedef enum {
 		/*!< Current cache mode of given cache instance */
 } ocf_cache_mode_t;
 
-#define OCF_SEQ_CUTOFF_PERCORE_STREAMS 128
-#define OCF_SEQ_CUTOFF_PERQUEUE_STREAMS 64
 #define OCF_SEQ_CUTOFF_MIN_THRESHOLD 1
 #define OCF_SEQ_CUTOFF_MAX_THRESHOLD 4294841344
-#define OCF_SEQ_CUTOFF_MIN_PROMOTION_COUNT 1
-#define OCF_SEQ_CUTOFF_MAX_PROMOTION_COUNT 65535
+#define OCF_SEQ_DETECT_MIN_PROMOTION_COUNT 1
+#define OCF_SEQ_DETECT_MAX_PROMOTION_COUNT 65535
+#define OCF_SEQ_DETECT_MIN_PROMOTION_THRESHOLD 0
+#define OCF_SEQ_DETECT_MAX_PROMOTION_THRESHOLD 4294841344
 
 typedef enum {
 	ocf_seq_cutoff_policy_always = 0,

inc/ocf_mngt.h

@@ -50,11 +50,11 @@ struct ocf_mngt_core_config {
 	uint32_t seq_cutoff_threshold;
 		/*!< Sequential cutoff threshold (in bytes) */
 
-	uint32_t seq_cutoff_promotion_count;
-		/*!< Sequential cutoff promotion request count */
+	uint32_t seq_detect_promotion_count;
+		/*!< Sequence detector stream promotion request count */
 
-	bool seq_cutoff_promote_on_threshold;
-		/*!< Sequential cutoff promote on threshold */
+	uint32_t seq_detect_promotion_threshold;
+		/*!< Sequence detector stream promotion threshold (in bytes) */
 
 	struct {
 		void *data;
@@ -75,8 +75,8 @@ static inline void ocf_mngt_core_config_set_default(
 {
 	cfg->try_add = false;
 	cfg->seq_cutoff_threshold = 1024;
-	cfg->seq_cutoff_promotion_count = 8;
-	cfg->seq_cutoff_promote_on_threshold = false;
+	cfg->seq_detect_promotion_count = 8;
+	cfg->seq_detect_promotion_threshold = 0;
 	cfg->user_metadata.data = NULL;
 	cfg->user_metadata.size = 0;
 }
@@ -1189,79 +1189,77 @@ int ocf_mngt_core_get_seq_cutoff_policy(ocf_core_t core,
  * @retval 0 Sequential cutoff promotion requets count has been set successfully
  * @retval Non-zero Error occured and request count hasn't been updated
  */
-int ocf_mngt_core_set_seq_cutoff_promotion_count(ocf_core_t core,
+int ocf_mngt_core_set_seq_detect_promotion_count(ocf_core_t core,
 		uint32_t count);
 
 /**
- * @brief Set sequential cutoff promotion request count for all cores in cache
+ * @brief Set sequence detector promotion request count for all cores in cache
  *
  * @attention This changes only runtime state. To make changes persistent
  *            use function ocf_mngt_cache_save().
  *
  * @param[in] cache Cache handle
  * @param[in] count promotion request count
  *
- * @retval 0 Sequential cutoff promotion request count has been set successfully
+ * @retval 0 Promotion request count has been set successfully
  * @retval Non-zero Error occured and request count hasn't been updated
  */
-int ocf_mngt_core_set_seq_cutoff_promotion_count_all(ocf_cache_t cache,
+int ocf_mngt_core_set_seq_detect_promotion_count_all(ocf_cache_t cache,
 		uint32_t count);
 
 /**
- * @brief Get core sequential cutoff promotion threshold
+ * @brief Get sequence detector promotion request count
  *
  * @param[in] core Core handle
  * @param[out] count promotion request count
  *
- * @retval 0 Sequential cutoff promotion request count has been get successfully
+ * @retval 0 Promotion request count has been retrieved successfully
  * @retval Non-zero Error occured
  */
-int ocf_mngt_core_get_seq_cutoff_promotion_count(ocf_core_t core,
+int ocf_mngt_core_get_seq_detect_promotion_count(ocf_core_t core,
 		uint32_t *count);
 
 /**
- * @brief Set whether to promote core sequential cutoff stream
- * to global structures when threshold is reached
+ * @brief Set sequence detector stream promotion threshold
  *
  * @attention This changes only runtime state. To make changes persistent
  *            use function ocf_mngt_cache_save().
  *
  * @param[in] core Core handle
- * @param[in] promote Whether to promote or not
+ * @param[in] threshold Promotion threshold (in bytes)
  *
- * @retval 0 Sequential cutoff promote on threshold has been set successfully
- * @retval Non-zero Error occured and promote on threshold hasn't been updated
+ * @retval 0 Promotion threshold has been set successfully
+ * @retval Non-zero Error occurred and threshold hasn't been updated
  */
-int ocf_mngt_core_set_seq_cutoff_promote_on_threshold(ocf_core_t core,
-		bool promote);
+int ocf_mngt_core_set_seq_detect_promotion_threshold(ocf_core_t core,
+		uint32_t threshold);
 
 /**
- * @brief Set whether to promote sequential cutoff stream
- * to global structures when threshold is reached for all cores in cache
+ * @brief Set sequence detector stream promotion threshold for all cores
  *
  * @attention This changes only runtime state. To make changes persistent
  *            use function ocf_mngt_cache_save().
  *
  * @param[in] cache Cache handle
- * @param[in] promote Whether to promote or not
+ * @param[in] threshold Promotion threshold (in bytes)
  *
- * @retval 0 Sequential cutoff promote on threshold has been set successfully
- * @retval Non-zero Error occured and promote on threshold hasn't been updated
+ * @retval 0 Promotion threshold has been set successfully
+ * @retval Non-zero Error occurred and threshold hasn't been updated
  */
-int ocf_mngt_core_set_seq_cutoff_promote_on_threshold_all(ocf_cache_t cache,
-		bool promote);
+int ocf_mngt_core_set_seq_detect_promotion_threshold_all(ocf_cache_t cache,
+		uint32_t threshold);
 
 /**
- * @brief Get core sequential cutoff promote on threshold switch value
+ * @brief Get sequence detector stream promotion threshold
  *
  * @param[in] core Core handle
- * @param[out] promote Promote on threshold
+ * @param[out] threshold Promotion threshold (in bytes)
  *
- * @retval 0 Sequential cutoff promote on threshold retrieved successfully
+ * @retval 0 Promotion threshold retrieved successfully
  * @retval Non-zero Error occured and value could not be retrieved
  */
-int ocf_mngt_core_get_seq_cutoff_promote_on_threshold(ocf_core_t core,
-		bool *promote);
+int ocf_mngt_core_get_seq_detect_promotion_threshold(ocf_core_t core,
+		uint32_t *threshold);
 
 /**
  * @brief Set cache fallback Pass Through error threshold

src/mngt/ocf_mngt_cache.c

@@ -33,6 +33,7 @@
 #include "../cleaning/cleaning.h"
 #include "../promotion/ops.h"
 #include "../concurrency/ocf_pio_concurrency.h"
+#include "../ocf_seq_cutoff.h"
 
 #define OCF_ASSERT_PLUGGED(cache) ENV_BUG_ON(!(cache)->device)
 
@@ -392,8 +393,8 @@ static void _ocf_mngt_deinit_added_cores(
 			ocf_volume_deinit(&core->front_volume);
 		}
 
-		if (core->seq_cutoff)
-			ocf_core_seq_cutoff_deinit(core);
+		ocf_core_seq_cutoff_deinit(core);
+		ocf_core_seq_detect_deinit(core);
 
 		env_free(core->counters);
 		core->counters = NULL;
@@ -479,10 +480,11 @@ static void _ocf_mngt_load_add_cores(ocf_pipeline_t pipeline,
 		if (!core->counters)
 			goto err;
 
-		ret = ocf_core_seq_cutoff_init(core);
+		ret = ocf_core_seq_detect_init(core);
 		if (ret < 0)
 			goto err;
 
+		ocf_core_seq_cutoff_init(core);
 		if (!core->opened) {
 			env_bit_set(ocf_cache_state_incomplete,
 					&cache->cache_state);

src/mngt/ocf_mngt_common.c

@@ -18,6 +18,7 @@
 #include "../ocf_logger_priv.h"
 #include "../ocf_queue_priv.h"
 #include "../engine/engine_common.h"
+#include "../ocf_seq_cutoff.h"
 
 /* Close if opened */
 void cache_mngt_core_deinit(ocf_core_t core)
@@ -132,6 +133,7 @@ void cache_mngt_core_remove_from_cache(ocf_core_t core)
 	ocf_cache_t cache = ocf_core_get_cache(core);
 
 	ocf_core_seq_cutoff_deinit(core);
+	ocf_core_seq_detect_deinit(core);
 	env_free(core->counters);
 	core->counters = NULL;
 	core->added = false;