Majordomo: Timeout, Heartbeat, Disconnects

[tschombe]

Can someone give me a hint on how to set
Broker / Worker Timeouts to get a stable Broker-Worker Connection on the
Majordomo Implementation?

I use 10 Seconds Heartbeats for Broker and Worker, both running on the localhost
but get every now and then a disconnect.

First Bug I found is in Broker-Constructor, if I pass a timeout the
m_heartbeatExpiry did not get adjusted accordingly. So I fixed this but still get these
disconnects.

[KamranShahid]

Can you please share the fix

[tschombe]

unfortunately I am not working with the sample anymore since I don't get it to run without problems.
so I don't have the sources anymore, sorry

[KamranShahid]

Ok thanks tschombe.
What is your analysis about the current library. Is it stable enough?
I need an implementation in my .net core 2.1.5 application where worker and broker should reside.
I am using v4.0.0.207-pre as it support .net standard version 2 and there were also some fixes mentioned there in this pre release

[KamranShahid]

Have updated following method in MDPBroker

 private Service ServiceRequired(string serviceName)
        {
            var svcExists = m_services.Exists(s => s.Name == serviceName);

            var svc = svcExists ? m_services.Find(s => s.Name == serviceName)
                          : new Service(serviceName);

            if (!svcExists)//this check is introduced
            {
                m_services.Add(svc);
            }
            // add service to the known services

            return svc;
        }

And also done some changes in HeartbeatInterval property initialization. Now code seems to be working quite fine at my end.

[tschombe]

Hi,

just get an email notification on the topic.
I did not use NetMQ currently but you should create a pull request
and contact one of the contributors so that your changes can go into the source on GitHub here!!!

THANKS for sharing your info here

[somdoron]

@KamranShahid can you make a pull request?

[KamranShahid]

Hi somdoron,
Haven't used this pull request feature on git hub.
Also I Have faced another issue [(https://github.com//issues/7)] but able to fix it by putting a try catch block in ProcessReceivedMessage method.
My implementation is now quite custom. I am uploading the code.
Thanks
MajorDomoPratternRelated.zip