Error with EssentialsX

[brianmay]

Describe the bug
According to the docs, this should work:

pluGET >> get EssentialsX
Searching for EssentialsX...
Found plugins:
 No.  Name                                      Downloads  Description
   1  EssentialsX                                 5606627  The modern Essentials suite for Spigot
                                                           and Paper.
   2  EssentialsXGUIBanner                          15860  A Nice GUI Temp-banning Plugin Alike The
                                                           One Used On The Performium Server!
   3  BkTeleport                                    12590  Teleport countdown on screen, Chat
                                                           clickable TPA and TPHERE, GUI for homes
                                                           and warps and more!
   4  KitPreviewEssentialsxaddon                     7848  Essentialsx addon
   5  EssentialsXSelectors                           7454  This minecraft plugin adds @a, @p, and
                                                           @r to EssentialsX Commands! Also adds
                                                           "@a"!
   6  GHomeEssentialsX                               4091  Use GUI for your all EssentialsX homes !
   7  iWarp                                          2118  Player warps expire unless expressly
                                                           renewed
   8  [U] - uSleep >> EssentialsX &                   836  A simple plugin that will change the way
      SuperVanish Support [1.14 - 1.16]                    you sleep, custom percentage, AFK and
                                                           Vanish support.
   9  EssentialsX                                     581  Adds /afk command with optional reason
                                                           (EssentialsX required)
  10  TraduccionpluginEssentialsX                     561  Traduccion, Essentials, Translate
Select your wanted resource (No.)(0 to exit): 1

 ● EssentialsX latest

    Downloaded         file → /home/brian/minecraft/linuxpenguins/plugins/EssentialsX-2.21.2.jar
Error: Downloaded plugin file was not a proper jar-file! Premium plugins are not supported!
Removing file...

As you can see it doesn't.

To Reproduce

See above.

Expected behavior

No errors.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Linux/NixOS 25.05

Additional context
Add any other context about the problem here.

[Neocky]

Hey @brianmay,

thanks for opening this issue.
I found two problems from overlooking the code currently:

• I'm pretty sure that the EssentialsX Team moved the direct download of the .jar-file from the Spigot page to an external website, here GitHub, since I wrote the docs. When I try to download EssentialsX from Spigot I get redirected to their latest release on GitHub: https://github.com/EssentialsX/Essentials/releases/tag/2.21.2
• pluGET assumes it is not a proper .jar-file which is correct. Preferably this should redirect to the correct download link or at least show the URL to the github release page for manual completion. Code in question:
  

  pluGET/src/plugin/plugin_downloader.py

  Lines 150 to 157 in 035ddd9

  	try:
  	with ZipFile(download_path, "r") as plugin_jar:
  	plugin_jar.open("plugin.yml", "r")
  	except:
  	rich_print_error("Error: Downloaded plugin file was not a proper jar-file! Premium plugins are not supported!")
  	rich_print_error("Removing file...")
  	os.remove(download_path)
  	return None

I will think of a solution.

[brianmay]

Thanks for looking into this.

Unfortunately it does seem that there is no good standardized way of downloading minecraft jar files. Yuck.

I am assuming that there probably is some github API to retrieve the files given a release.

Maybe: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#get-a-release-by-tag-name

This in turn might provide a URL that will work with the existing code.