Inconsistencies and problems finding weather files

[jmarrec]

I have some regression tests that fail because the OSM model is the one defining the weather file, and it has a file:/// prefix (coming from the ChangeBuildingLocation measure)

OS:WeatherFile,
  {e0d9ac65-2462-4210-a9be-27806207ed2f}, !- Handle
  Chicago Ohare Intl Ap,                  !- City
  IL,                                     !- State Province Region
  USA,                                    !- Country
  TMY3,                                   !- Data Source
  725300,                                 !- WMO Number
  41.98,                                  !- Latitude {deg}
  -87.92,                                 !- Longitude {deg}
  -6,                                     !- Time Zone {hr}
  201,                                    !- Elevation {m}
  file:////home/julien/Software/Others/OpenStudio-resources/weatherdata/USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw, !- Url
  ;      

I'm not terribly familiar with openstudio-workflow-gem but I see at least three locations where it's trying to locate the weather file from the model.

Only one of these implementation does work in my case, the one in util/weather_file.rb that strips out the initial file:// in the weatherfile path. See util/weather_file.rb#L79:L99

jobs/run_initialization.rb and util/measure.rb do not work.

These two should call OpenStudio::Workflow::Util::WeatherFile::get_weather_file method so that it's centrally defined and proper. (As far as I can tell, WeatherFile::get_weather_file isn't actually used anywhere inside the workflow gem itself)