Improve cmake targets for code linters#58
Merged
Matt Shin (matthewrmshin) merged 1 commit intoJun 8, 2026
Conversation
Collaborator
Author
|
CI clang build failure on oops source code nothing to do with this change? |
Matt Shin (matthewrmshin)
requested review from
David Davies (DJDavies2),
DanStoneMO and
Josh Colclough (mo-joshuacolclough)
Modify cpplint target to use `cpplint` from the environment. ~Remove cpplint.py from lfric-jedi's source tree.~ cpplint 2.0.2 happiness - Update filter categories. - Fix new violations, `build/include_what_you_use`. Add cmakelint to CI and fix violations.
Matt Shin (matthewrmshin)
force-pushed
the
feature/cmake-cpplint-fortitude
branch
from
11e0996 to
df11965
Compare
DanStoneMO
approved these changes
Jun 8, 2026
Josh Colclough (mo-joshuacolclough)
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify cpplint target to use
cpplintfrom the environment.Remove cpplint.py from lfric-jedi's source tree.cpplint 2.0.2 happiness
build/include_what_you_use.Add cmakelint to CI and fix violations.