Skip to content

Using non-Standard samplers can crash SM / sampler list seems to depend on running model #1534

@Kunicross

Description

@Kunicross

What happened?

After launching SM only a limited list of Samplers is shown:
Image

After launching comfyui the list gets expanded by additional samplers:

Image

Sometimes after creation the sampler is empty (probably related) and has to be selected anew (minor issue) but sometimes SM does do a full, hard crash.

The crash did happen every time when I tried to save one of the non default samplers as interference default - while writing the report that did not crash as reliable but seem to happen if saving gradient_estimation as default, restarting, starting comfyui, then going back to the defaults and save them again. (without comfy running the field is just empty:

Image Image

this in itself is not the worst way for it to happen but sometimes it does happen in normal operations and is pretty annoying since there is no way to save when it happens. Defaults have been set to normal samplers but that does not seem to help when using more exotic samplers.

Full error message

ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection

   at System.Collections.ObjectModel.Collection`1.System.Collections.IList.get_Item(Int32 index)
   at Avalonia.Controls.ItemsSourceView`1.GetAt(Int32 index)
   at Avalonia.Controls.Selection.SelectedItems`1.GetEnumerator()+MoveNext()
   at System.Linq.Enumerable.<ToArray>g__EnumerableToArray|314_0[TSource](IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Avalonia.Controls.Selection.InternalSelectionModel.OnSelectionChanged(Object sender, SelectionModelSelectionChangedEventArgs e)
   at Avalonia.Controls.Selection.SelectionModel`1.CommitOperation(Operation operation, Boolean raisePropertyChanged)
   at Avalonia.Controls.Selection.InternalSelectionModel.OnSourceCollectionChangeFinished()
   at Avalonia.Controls.Utils.CollectionChangedEventManager.Entry.<Avalonia.Utilities.IWeakEventSubscriber<System.Collections.Specialized.NotifyCollectionChangedEventArgs>.OnEvent>g__Notify|6_0(INotifyCollectionChanged incc, NotifyCollectionChangedEventArgs args, WeakReference`1[] listeners)
   at Avalonia.Threading.DispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean fromExplicitBackgroundProcessingCallback)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam)
   at Avalonia.Win32.Interop.UnmanagedMethods.DispatchMessage(MSG& lpmsg)
   at Avalonia.Win32.Win32DispatcherImpl.RunLoop(CancellationToken cancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl)
   at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.StartCore(String[] args)
   at StabilityMatrix.Avalonia.Program.Main(String[] args)

Steps to reproduce

  • Start SM
  • launch comfy UI
  • go to checkpoint manager -> right click -> edit metadata
  • at Inference Defaults select one of the non capital samplers from the end of the list
  • save (sometimes crashes right here, maybe if there had been on of the samplers saved there before)
  • restart comfyui
  • edit Inference Defaults for the model again -> save -> crashes all the time

Relevant logs

Version

2.15.5

What Operating System are you using?

Windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions