Skip to content

ShellScriptHandler plugin does not conform to base class interface #7

Description

@srikanth-viswanathan

The declaration of execute_command in BaseHandler is:

        def execute_command(self):

However, the ShellScriptHandler overrides it as:

    def execute_command(self, script, arguments):

atropos.py also assumes this interface:

        handler_class = getattr(handler_module, handler_name)
        handler = handler_class(self.config_dir, target,
                                self.logger_instance, verbose=True)
        handler.authenticate()
        command_status, command_output, command_error = \
            handler.execute_command(coordinate, arguments)

I think atropos.py is meant to use the base class interface to remove the assumption that every handler has a "coordinate". Let me know if you accept patches and I'll work on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions