is_file_gdshell_command issue with Godot 4.4 when loading resources through UID

[davidjbrodeur]

VERSION:
Godot v4.4.1.stable (9a3480ff1) - Ubuntu 22.04.3 LTS 22.04 on Wayland - X11 display driver, Multi-window, 1 monitor - OpenGL 3 (Compatibility) - SVGA3D; build: RELEASE; LLVM; - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (2 threads)

INTENT:
Trying to boot my game with a newly "installed" GDShell

CONTEXT:
I did the install steps as per the docs, changed nothing.

WHAT HAPPENS:
I get 17 errors. 16 of them are a pair of 2 errors (one is "No loader found for resource X" and the other is "Error loading resource X":
E 0:00:00:819 gdshell_command_db.gd:87 @ is_file_gdshell_command(): No loader found for resource: res://addons/gdshell/commands/plugin_integrations/monitor_overlay/monitor.gd.uid (expected type: GDScript)
<C++ Error> Method/function failed. Returning: Ref()
<C++ Source> core/io/resource_loader.cpp:359 @ _load()
gdshell_command_db.gd:87 @ is_file_gdshell_command()
gdshell_command_db.gd:83 @ ()
gdshell_command_db.gd:83 @ get_command_file_paths_in_directory()
gdshell_command_db.gd:20 @ add_commands_in_directory()
gdshell_main.gd:52 @ setup_command_db()
gdshell_main.gd:36 @ setup_with_default_values()
gdshell_main.gd:29 @ _ready()
E 0:00:00:819 gdshell_command_db.gd:87 @ is_file_gdshell_command(): Error loading resource: 'res://addons/gdshell/commands/plugin_integrations/monitor_overlay/monitor.gd.uid'.
<C++ Error> Condition "err != OK" is true. Returning: ret
<C++ Source> core/core_bind.cpp:76 @ load()
gdshell_command_db.gd:87 @ is_file_gdshell_command()
gdshell_command_db.gd:83 @ ()
gdshell_command_db.gd:83 @ get_command_file_paths_in_directory()
gdshell_command_db.gd:20 @ add_commands_in_directory()
gdshell_main.gd:52 @ setup_command_db()
gdshell_main.gd:36 @ setup_with_default_values()
gdshell_main.gd:29 @ _ready()

Plus I also have
E 0:00:00:848 gdshell_command_runner.gd:110 @ _execute_command(): Dictionary is in read-only state.
<C++ Error> Condition "_p->read_only" is true.
<C++ Source> core/variant/dictionary.cpp:303 @ merge()
gdshell_command_runner.gd:110 @ _execute_command()
gdshell_command_runner.gd:51 @ execute()
gdshell_main.gd:75 @ execute()
gdshell_main.gd:69 @ execute_autorun()
gdshell_main.gd:40 @ setup_with_default_values()
gdshell_main.gd:29 @ _ready()
This corresponds to line:
result.merge(GDShellCommand.DEFAULT_COMMAND_RESULT)

WHAT I WANT TO HAPPEN:
Load the resources appropriately so I can access the addon.

Thanks a lot! This thing looks awesome, so I hope I can use it.

[Kubulambula]

Thank you for the detailed description!
I was able to reproduce the issue, but it seems to be working even with all the errors present.
Does it work for you too? By default basic GDShell window can be shown by pressing " ` " and try running any command like man. If it works for you too, you can continue using this version for now.

Right now, I am rewriting GDShell basically from scratch with minimal impact on user commands and plan to develop it more actively, but with my schedule it might take a few more weeks.

[davidjbrodeur]

I'll be honest I'm super anal about warnings and errors, so when I saw it, I worked on it for hours without actually trying it lol. I'll give it a go. If it works I might use your solution (right now I have my old console using expression parsing, but yours is much better and much more elegant from what I can see).

[Kubulambula]

Yeah I hate all errors and warnings as well so I really understand.
The parser in the released version is the biggest reason I decided to rewrite it in first place. Now it is a full precedence parser & AST compiler, which will allow you to even store precompiled commands as Dictionaries/JSON and run them with bind buttons for example.

This issue showed me that even before the runtime loading of .gd files was a bit janky and the introduction of uid just showed how broken it was., so thank you for pointing it out <3

[davidjbrodeur]

So I tried it even with the errors and it does work. So I'll be using this for now and update it when you launch your new version in the future! Thanks a lot for the return.