feat(ui): add Activity tab with graphs to TUI statistics dialog#1038
Merged
Conversation
Add a new "Activity" tab to the statistics dialog showing productivity pattern visualizations using textual-plotext: - Hourly completion line chart (0-23h) - Day-of-week completion line chart (Mon-Sun) - Estimation accuracy scatter plot (estimated vs actual, 95th percentile clipped) - Monthly completion trend line chart Core changes: - Add ActivityPatternStatistics DTO with hourly/daily completion data - Add estimation_pairs to EstimationAccuracyStatistics for scatter plot - Add _calculate_activity_patterns() to TaskStatisticsCalculator - Wire new fields through server, client, presenter, and view model layers - Add textual-plotext dependency to taskdog-ui
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully adds an Activity tab to the TUI statistics dialog with productivity visualizations. The implementation is clean and well-integrated across all layers:
Strengths:
- Proper separation of concerns with data flowing through core → server → client → UI layers
- Consistent with existing codebase patterns and conventions
- All tests passing (3,789 total tests) with strict mypy compliance
- Good handling of edge cases (empty data scenarios)
- Appropriate use of textual-plotext for visualization
The feature is ready for merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActivityPatternStatisticsDTO andestimation_pairsfield wired through all layers (core → server → client → UI)textual-plotextdependency to taskdog-uiTest plan