diff --git a/instance_segmentation.py b/instance_segmentation.py index 4fb2d24..b4c8cb8 100644 --- a/instance_segmentation.py +++ b/instance_segmentation.py @@ -140,7 +140,26 @@ def prepare_data(self): "Cleaned_LowRes_13434_overlapping_pairs.tar.xz?raw=true" filename, headers = urllib.request.urlretrieve(url, tar_path) with tarfile.open(tar_path, 'r') as f: - f.extractall('data') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, "data") def setup(self, stage=None): # original dataset diff --git a/semantic_segmentation.py b/semantic_segmentation.py index 364398b..470df3d 100644 --- a/semantic_segmentation.py +++ b/semantic_segmentation.py @@ -104,7 +104,26 @@ def prepare_data(self): "Cleaned_LowRes_13434_overlapping_pairs.tar.xz?raw=true" filename, headers = urllib.request.urlretrieve(url, tar_path) with tarfile.open(tar_path, 'r') as f: - f.extractall('data') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, "data") def setup(self, stage=None): # original dataset