Skip to content

Commit befae3e

Browse files
xingsy97rzhao271
andauthored
timeline: fix memory leak when toggling pane visibility (microsoft#304668)
* timeline: dispose previous visibility subscriptions before recreating * retrigger CI --------- Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
1 parent 3bafa7d commit befae3e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

src/vs/workbench/contrib/timeline/browser/timelinePane.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -883,6 +883,7 @@ export class TimelinePane extends ViewPane {
883883
override setVisible(visible: boolean): void {
884884
if (visible) {
885885
this.extensionService.activateByEvent('onView:timeline');
886+
this.visibilityDisposables?.dispose();
886887
this.visibilityDisposables = new DisposableStore();
887888

888889
this.editorService.onDidActiveEditorChange(this.onActiveEditorChanged, this, this.visibilityDisposables);

0 commit comments

Comments
 (0)