`estimateFinalLoc()` versus `estimateSpawnLoc()`

[mackerman44]

I'm a little confused here. The function setInitialValues() appears to use the function estimateSpawnLoc(); however, the repo doesn't seem to have a estimateSpawnLoc() function... it instead had the estimateFinalLoc() function. I ported over an estimateSpawnLoc() function from ryankinzer/DABOM in KevinSee/PITcleanr@c19a45a , which was then renamed in KevinSee/PITcleanr@1a7406a.

I haven't had a moment to look at the differences between the two, but seems worth resolving. It appears that @KevinSee made some changes to estimateFinalLoc() related to recent "PITcleanr_lite" modifications.

[KevinSee]

I just caught this as well. I essentially just did some renaming between estimateSpawnLoc and estimateFinalLoc so it appeared more applicable for downstream moving fish (e.g. juveniles). I just made an update in the develop branch of DABOM in the setInitialValues function to use estimateFinalLoc instead. Super simple, just changed a couple lines of code to:

spawn_node = estimateFinalLoc(filter_ch) %>% select(tag_code, spawn_node = final_node) %>%

[KevinSee]

I also updated the summarizeTagData() function to use estimateFinalLoc() instead of estimateSpawnLoc(), again to make it more generic for upstream OR downstream movement.

@mackerman44 , are there any other places where estimateSpawnLoc() is used, that you're aware of? If not, I'd like to go ahead and delete it from the package.