Get an Error by using workload

[grizzly69]

Hello at All,

if i run workload on redmine 3.4.2 stable i get the following error:

ActiveRecord::StatementInvalid (TinyTds::Error: Incorrect syntax near the keyword 'end'.: EXEC sp_executesql N'SELECT COUNT(*) FROM [wl_national_holidays] WHERE (start <= ''01-14-2018'' AND end >= ''01-14-2018'')

What does it mean and what is the problem, can somebody help me?

Thanks.

[samaust]

It's a bug.

"end" is a reserved keyword.
Source : https://www.postgresql.org/docs/current/static/sql-keywords-appendix.html

https://github.com/JostBaron/redmine_workload/blob/master/lib/dateTools.rb#L51
is

if WlNationalHoliday.where("start <= ? AND end >= ?", day, day).empty? then

I think we need to add the table name before end as follows

if WlNationalHoliday.where("start <= ? AND wl_national_holidays.end >= ?", day, day).empty? then