Merge pull request #31 from Johnaverse/fix/sonarqube-code-quality-v1.1.0

Fix SonarQube issues and bump version to 1.1.0

Author: Johnaverse

dataService.js

@@ -1316,13 +1316,39 @@ export function getRelationsById(chainId) {
  * @param {number} maxDepth - Maximum traversal depth (default: 2)
  * @returns {Object|null} Traversal result with nodes and edges, or null if chain not found
  */
+function collectRelationEdges(chain, chainId, depth, visited, edges, queue, seenEdges) {
+  const relations = chain.relations || [];
+  for (const rel of relations) {
+    if (rel.chainId === undefined) continue;
+
+    // Deduplicate bidirectional edges (A→B and B→A with same kind) using O(1) Set lookup
+    const a = Math.min(chainId, rel.chainId);
+    const b = Math.max(chainId, rel.chainId);
+    const edgeKey = `${a}-${b}-${rel.kind}`;
+    if (!seenEdges.has(edgeKey)) {
+      seenEdges.add(edgeKey);
+      edges.push({
+        from: chainId,
+        to: rel.chainId,
+        kind: rel.kind,
+        source: rel.source
+      });
+    }
+
+    if (!visited.has(rel.chainId)) {
+      queue.push({ chainId: rel.chainId, depth: depth + 1 });
+    }
+  }
+}
+
 export function traverseRelations(startChainId, maxDepth = 2) {
   if (!cachedData.indexed) return null;
 
   const startChain = cachedData.indexed.byChainId[startChainId];
   if (!startChain) return null;
 
   const visited = new Set();
+  const seenEdges = new Set();
   const queue = [{ chainId: startChainId, depth: 0 }];
   const nodes = [];
   const edges = [];
@@ -1342,28 +1368,8 @@ export function traverseRelations(startChainId, maxDepth = 2) {
       depth
     });
 
-    if (depth >= maxDepth) continue;
-
-    const relations = chain.relations || [];
-    for (const rel of relations) {
-      if (rel.chainId === undefined) continue;
-
-      // Deduplicate bidirectional edges (A→B and B→A with same kind)
-      const a = Math.min(chainId, rel.chainId);
-      const b = Math.max(chainId, rel.chainId);
-      const isDuplicate = edges.some(e => Math.min(e.from, e.to) === a && Math.max(e.from, e.to) === b && e.kind === rel.kind);
-      if (!isDuplicate) {
-        edges.push({
-          from: chainId,
-          to: rel.chainId,
-          kind: rel.kind,
-          source: rel.source
-        });
-      }
-
-      if (!visited.has(rel.chainId)) {
-        queue.push({ chainId: rel.chainId, depth: depth + 1 });
-      }
+    if (depth < maxDepth) {
+      collectRelationEdges(chain, chainId, depth, visited, edges, queue, seenEdges);
     }
   }
 

index.js

@@ -6,6 +6,7 @@ import fastifyStatic from '@fastify/static';
 import { readFile } from 'node:fs/promises';
 import { basename, resolve, dirname, join } from 'node:path';
 import { fileURLToPath as toFilePath } from 'node:url';
+import pkg from './package.json' with { type: 'json' };
 import { loadData, initializeDataOnStartup, getCachedData, searchChains, getChainById, getAllChains, getAllRelations, getRelationsById, getEndpointsById, getAllEndpoints, getAllKeywords, validateChainData, traverseRelations, countChainsByTag } from './dataService.js';
 import { getMonitoringResults, getMonitoringStatus, startRpcHealthCheck } from './rpcMonitor.js';
 import {
@@ -202,7 +203,7 @@ export async function buildApp(options = {}) {
       return sendError(reply, 400, 'Invalid chain ID');
     }
 
-    const depth = request.query.depth !== undefined ? parseIntParam(request.query.depth) : 2;
+    const depth = request.query.depth === undefined ? 2 : parseIntParam(request.query.depth);
     if (depth === null || depth < 1 || depth > 5) {
       return sendError(reply, 400, 'Invalid depth. Must be between 1 and 5');
     }
@@ -456,7 +457,7 @@ export async function buildApp(options = {}) {
   fastify.get('/', async (request, reply) => {
     return {
       name: 'Chains API',
-      version: '1.0.0',
+      version: pkg.version,
       description: 'API query service for blockchain chain data from multiple sources',
       endpoints: {
         '/health': 'Health check and data status',

mcp-tools.js

@@ -352,7 +352,7 @@ function handleTraverseRelations(args) {
     return errorResponse('Invalid chain ID');
   }
 
-  const maxDepth = depth !== undefined ? depth : 2;
+  const maxDepth = depth ?? 2;
   if (typeof maxDepth !== 'number' || maxDepth < 1 || maxDepth > 5) {
     return errorResponse('Invalid depth. Must be between 1 and 5');
   }
@@ -433,7 +433,7 @@ function handleGetRpcMonitorById(args) {
   ];
   for (const ep of chainResults) {
     const block = ep.blockNumber == null ? '' : ` — block #${ep.blockNumber}`;
-    const latency = ep.latencyMs != null ? ` [${ep.latencyMs}ms]` : '';
+    const latency = ep.latencyMs == null ? '' : ` [${ep.latencyMs}ms]`;
     const client = ep.clientVersion && ep.clientVersion !== 'unavailable' ? ` (${ep.clientVersion})` : '';
     lines.push(
       `- **${ep.status}** ${ep.url}${block}${latency}${client}`,

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "chains-api",
-  "version": "1.0.12",
+  "version": "1.1.0",
   "description": "API query service for blockchain chain data from multiple sources",
   "main": "index.js",
   "type": "module",