You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.github/workflows/ci.yml runs lint/typecheck/test:unit/test:integration/build/bazel but not pnpm test:component (vitest.component.config.ts, tests/e2e/**). The render-level checkout tests added in fix(payments): normalize public card payment method boundary #99 (tests/e2e/hybrid-checkout-drawer.test.ts, tests/e2e/payment-selector.test.ts) are therefore validated only locally. Add the component lane to CI.
Sequencing: wait for #96 to land, then a small PR can do both.
Two follow-ups deferred from PR #99 review because the owning files conflict with open PRs:
vitest.config.ts(owned by open PR chore: land devshell, docs, and toolchain truth normalization (TIN-89) #96) excludessrc/payments/types.tsfrom coverage with the comment 'Types only'. That was already stale (createPaymentRegistrylives there) and is more so after fix(payments): normalize public card payment method boundary #99: the file now hosts the public payment-method id normalization runtime (toPublicPaymentMethodId/toInternalPaymentMethodId/isCardPaymentMethodId/isManualPaymentMethodId,toPublicPaymentMethodOption, registry resolution + dedupe). None of it counts toward the 70% threshold gate. Remove the exclude after chore: land devshell, docs, and toolchain truth normalization (TIN-89) #96 lands..github/workflows/ci.ymlruns lint/typecheck/test:unit/test:integration/build/bazel but notpnpm test:component(vitest.component.config.ts,tests/e2e/**). The render-level checkout tests added in fix(payments): normalize public card payment method boundary #99 (tests/e2e/hybrid-checkout-drawer.test.ts,tests/e2e/payment-selector.test.ts) are therefore validated only locally. Add the component lane to CI.Sequencing: wait for #96 to land, then a small PR can do both.