Summary text assumes quartets

[cameronc137]

It looks like the summary text assumes quartets and this is breaking our downstream good time, events, and charge measurements as well.

Probably we can work around this in the downstream codes, but it should be fixed here too.

[cameronc137]

japan/Analysis/src/QwPromptSummary.cc

Line 159 in 7580f72

this->SetNumGoodEvents(4*temp*temp);

[rahmans1]

Yeah. It assumes quartets. Downside of hardcoding. Probably do this through a configuration file. I have an update to prompt summary in the works but it's stalled because of other priorities. Will try to get it in as soon as I possibly can.

[sanghwapark]

This needs to be fixed relatively soon even if it's again hard-coded fix so that we have our charge counter works properly for the shift crew. We could live with correcting the charge counter back, but we need a fix for this and probably re-prompt for the future.

[cameronc137]

To stop-gap hack this to work from the 240/octet time onwards (until we fix the prompt summary and respin) I've multiplied runs after 3874-> good charge by 2x in the acc_charge.py script and it shows +1.5 more Coulombs as expected.

[cameronc137]

This was worked around during PREX, the thing that cared was our python script for getting charge into the charge plotter, but we should probably fix this for Respins so we don't have wrong information floating around.

@rr521111

[sanghwapark]

it's the other way around.. charge script kept assuming quartets because the summary output didn't get updated. I agree, it would be good to get it fixed for respin.

[rahmans1]

I remember trying to solve this and then getting distracted with other stuff. I will take a look tomorrow at the branch I was working on.

[paulmking]

@rahmans1: @rr521111 and I talked last night about what ought to be a quick solution, so check in with him about it.

[cameronc137]

Has there been progress on this?

[paulmking]

I thought we had it fixed in develop before I merged back into operations. What is the current behavior? Sent from my mobile device.

…

________________________________ From: Cameron Clarke <notifications@github.com> Sent: Thursday, January 9, 2020 4:54:40 PM To: JeffersonLab/japan <japan@noreply.github.com> Cc: Paul King <pking@jlab.org>; Comment <comment@noreply.github.com> Subject: [EXTERNAL] Re: [JeffersonLab/japan] Summary text assumes quartets (#240) Has there been progress on this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_japan_issues_240-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAB55ZLDR6MOQICCGZAP2BM3Q46MKBA5CNFSM4IKL2T52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIR5NOA-23issuecomment-2D572774072&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=0j7LsbAZ7ALovZkXAFR8Dw&m=X1Uo3crcYohQnioiBu7_9-triNGiknxWbvIpUzGm4wY&s=mU3AQ9u0ROQcLdt9o0LR-tZKuCskpt58IzlvKuvp2bs&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AB55ZLA3JPIU75XRHVMBEVDQ46MKBANCNFSM4IKL2T5Q&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=0j7LsbAZ7ALovZkXAFR8Dw&m=X1Uo3crcYohQnioiBu7_9-triNGiknxWbvIpUzGm4wY&s=JNUYtK2bPLI7ZkwyYHbEmHAZQPjvGn7oktnp54NOhwE&e=>.

[cameronc137]

Yes, I think it’s fine. I was seeing an issue with pvdb, but it was a too-aggressive cut from Sanghwa’s script that did it.