refactor(cli): extract duplicated getCurrentExecutablePath helper#61
Open
valentinozegna wants to merge 1 commit into
Open
refactor(cli): extract duplicated getCurrentExecutablePath helper#61valentinozegna wants to merge 1 commit into
valentinozegna wants to merge 1 commit into
Conversation
getCurrentExecutablePath() was copy-pasted verbatim in both src/cli/commands.ts and src/cli/updater.ts. Move it to a shared src/cli/executable.ts and import it in both call sites. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCurrentExecutablePath()was copy-pasted verbatim in two CLI files:src/cli/commands.ts:128src/cli/updater.ts:204This extracts it into a shared
src/cli/executable.tsand imports it in both. No behavior change — the body is identical to the originals (which were byte-for-byte the same logic).Verification
npm run type-check✅npm run lint✅npm test✅ (404/404)Context
Found during a codebase audit. Low-risk dedupe; the two copies were a refactoring hazard (fixing a bug in one would miss the other).
https://claude.ai/code/session_01LGUEJTmg3MJDiCSZqzL5ED
Generated by Claude Code