how can i return other "hasMany" relationships in link part

[jackypu]

Dear @neomerx ,

I'am using the old version of limoncello-shot for our project. Now, when get /posts/1,it returns:

{
"data": {
"type": "posts",
"id": "1",
"attributes": {},
"relationships": {
"comments": {
"data": []
}
},
"links": {
"self": "http://localhost:8888/posts/1"
}
}
}

I am wondering if i can return other "hasMany" relationship links in the links node,like “comments” part as below:

{
"data": {
"type": "posts",
"id": "1",
"attributes": {//hide
},
"relationships": {
"comments": {
"data": []
}
},
"links": {
"self": "http://localhost:8888/posts/1",
"comments": "http://localhost:8888/posts/1/comments",

    }
}

}

Thanks very much!

[neomerx]

For example you have something like this in your controller https://github.com/neomerx/limoncello-illuminate/blob/master/app/Http/Controllers/Api/BoardsController.php#L39

How you could add links to top level links section?

If you go to getPagedDataResponse definition you would see it's a shortcut for

    public function getPagedDataResponse(PagedDataInterface $data, $statusCode = self::HTTP_OK)
    {
        return $this->getContentResponse($data->getData(), $statusCode, $data->getLinks(), $data->getMeta());
    }

The parameter $data->getLinks() is what you need. You can add your links something like

$myLinks = array_merge($data->getLinks(), [
    new Link(...),
]);

return $this->getContentResponse($data->getData(), $statusCode, $myLinks, $data->getMeta());

see Links docs for parameters description

[jackypu]

Thanks,
The background is: I am now working on "neomerx/limoncello": "^0.5.0", it's not the latest version that using docker but using "php artisan serve --port=8888" as dev server.

I'v tried the method you'v told on my current version, the codes are:

$myLinks = new Link("/comments/");
return $this->getResponse($data, Response::HTTP_OK, [$myLinks]);

And the formatted JSON string is:

{
"links": [
    "http://localhost:8888/comments/"
  ],
"data": {
    "type": "posts",
    "id": "1",
    "attributes": {},
    "relationships": {
        "comments": {
       "data": []
    }
  } ,
  "links": {
      "self": "http:\/\/localhost:8888\/posts\/1"
   }
 }
}

That is to say: it's not under the data node, but the top of the returned JSON object.

I tried preparing data "posts" with it's relationships "comments" :

$data = Post::with('comments')->findOrFail($idx);
return $this->getResponse($data)

But it's still not working. So I'am wondering if it's because my version of this project is too old to be fine?