diff --git a/.github/classroom/autograding.json b/.github/classroom/autograding.json index c6eb57d..3097ea2 100644 --- a/.github/classroom/autograding.json +++ b/.github/classroom/autograding.json @@ -3,7 +3,7 @@ { "name": "Initial step", "setup": "", - "run": "mvn clean package", + "run": "mvn clean package -DskipTests=true", "input": "", "output": "", "comparison": "included", @@ -30,16 +30,6 @@ "timeout": 10, "points": 10 }, - { - "name": "Initial tests", - "setup": "", - "run": "mvn -q test", - "input": "", - "output": "", - "comparison": "included", - "timeout": 10, - "points": 10 - }, { "name": "Cucumber final tests", "setup": "", diff --git a/.github/workflows/classroom.yml b/.github/workflows/classroom.yml index 8e05703..dd41dad 100644 --- a/.github/workflows/classroom.yml +++ b/.github/workflows/classroom.yml @@ -8,4 +8,9 @@ runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - name: Set up JDK 16 + uses: actions/setup-java@v2 + with: + java-version: '16' + distribution: 'adopt' - uses: education/autograding@v1 diff --git a/.github/workflows/pipeline.yml b/.github/workflows/pipeline.yml index 97c5ad6..0fb41d4 100644 --- a/.github/workflows/pipeline.yml +++ b/.github/workflows/pipeline.yml @@ -76,24 +76,24 @@ jobs: push: true tags: ${{ secrets.DOCKER_USERNAME }}/re21 - deploy-app: - needs: publish-image - runs-on: ubuntu-latest - steps: - - name: Pull the released image - run: docker pull ${{ secrets.DOCKER_USERNAME }}/re21 - - name: connect to the Heroku registry - run: | - docker login --username=_ \ - --password=${{ secrets.HEROKU_API_KEY }} \ - registry.heroku.com - - name: prepare the released image for deployment - run: | - docker tag ${{ secrets.DOCKER_USERNAME }}/re21 \ - registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web - - name: push the image to heroku - run: docker push registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web - - name: release the image into a new container - run: heroku container:release web -a ${{ secrets.HEROKU_APP_NAME }} - env: - HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }} \ No newline at end of file +# deploy-app: +# needs: publish-image +# runs-on: ubuntu-latest +# steps: +# - name: Pull the released image +# run: docker pull ${{ secrets.DOCKER_USERNAME }}/re21 +# - name: connect to the Heroku registry +# run: | +# docker login --username=_ \ +# --password=${{ secrets.HEROKU_API_KEY }} \ +# registry.heroku.com +# - name: prepare the released image for deployment +# run: | +# docker tag ${{ secrets.DOCKER_USERNAME }}/re21 \ +# registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web +# - name: push the image to heroku +# run: docker push registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web +# - name: release the image into a new container +# run: heroku container:release web -a ${{ secrets.HEROKU_APP_NAME }} +# env: +# HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }} diff --git a/Dockerfile b/Dockerfile index 6ac2bd1..7c3127e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,4 +4,4 @@ FROM openjdk:16-alpine ENV PORT=8080 WORKDIR /app COPY target/re-21-SHADED.jar . -CMD ["java", "-jar", "re-21-SHADED.jar"] \ No newline at end of file +CMD ["java", "-jar", "re-21-SHADED.jar"] diff --git a/src/main/java/Order.java b/src/main/java/Order.java index b265e21..af6ae1c 100644 --- a/src/main/java/Order.java +++ b/src/main/java/Order.java @@ -7,7 +7,6 @@ public class Order { private List contents = new LinkedList<>(); private double taxes = 0.0; - private String owner; public void setOwner(String who) { this.owner = who; } private String recipient; diff --git a/src/test/java/OrderUnitTest.java b/src/test/java/OrderUnitTest.java index 6855138..33aaa2c 100644 --- a/src/test/java/OrderUnitTest.java +++ b/src/test/java/OrderUnitTest.java @@ -1,5 +1,7 @@ import org.junit.Test; + import java.util.List; + import static org.junit.Assert.assertEquals; public class OrderUnitTest { @@ -7,6 +9,7 @@ public class OrderUnitTest { @Test public void empty_order_by_default() { Order o = new Order(); + o.setOwner("Romeo"); o.setRecipient("Juliet"); List drinks = o.getDrinks();