some more rules

Author: Kraysent

app/presentation/adminapi/interface.py

@@ -338,49 +338,49 @@ class SetCrossmatchResultsResponse(pydantic.BaseModel):
 
 class Actions(abc.ABC):
     @abc.abstractmethod
-    def add_data(self, request: AddDataRequest) -> AddDataResponse:
+    def add_data(self, r: AddDataRequest) -> AddDataResponse:
         pass
 
     @abc.abstractmethod
-    def create_table(self, request: CreateTableRequest) -> tuple[CreateTableResponse, bool]:
+    def create_table(self, r: CreateTableRequest) -> tuple[CreateTableResponse, bool]:
         pass
 
     @abc.abstractmethod
-    def get_table(self, request: GetTableRequest) -> GetTableResponse:
+    def get_table(self, r: GetTableRequest) -> GetTableResponse:
         pass
 
     @abc.abstractmethod
-    def get_table_list(self, request: GetTableListRequest) -> GetTableListResponse:
+    def get_table_list(self, r: GetTableListRequest) -> GetTableListResponse:
         pass
 
     @abc.abstractmethod
-    def patch_table(self, request: PatchTableRequest) -> PatchTableResponse:
+    def patch_table(self, r: PatchTableRequest) -> PatchTableResponse:
         pass
 
     @abc.abstractmethod
-    def create_source(self, request: CreateSourceRequest) -> CreateSourceResponse:
+    def create_source(self, r: CreateSourceRequest) -> CreateSourceResponse:
         pass
 
     @abc.abstractmethod
-    def login(self, request: LoginRequest) -> LoginResponse:
+    def login(self, r: LoginRequest) -> LoginResponse:
         pass
 
     @abc.abstractmethod
-    def get_records(self, request: GetRecordsRequest) -> GetRecordsResponse:
+    def get_records(self, r: GetRecordsRequest) -> GetRecordsResponse:
         pass
 
     @abc.abstractmethod
-    def get_crossmatch_records(self, request: GetRecordsCrossmatchRequest) -> GetRecordsCrossmatchResponse:
+    def get_crossmatch_records(self, r: GetRecordsCrossmatchRequest) -> GetRecordsCrossmatchResponse:
         pass
 
     @abc.abstractmethod
-    def get_record_crossmatch(self, request: GetRecordCrossmatchRequest) -> GetRecordCrossmatchResponse:
+    def get_record_crossmatch(self, r: GetRecordCrossmatchRequest) -> GetRecordCrossmatchResponse:
         pass
 
     @abc.abstractmethod
-    def save_structured_data(self, request: SaveStructuredDataRequest) -> SaveStructuredDataResponse:
+    def save_structured_data(self, r: SaveStructuredDataRequest) -> SaveStructuredDataResponse:
         pass
 
     @abc.abstractmethod
-    def set_crossmatch_results(self, request: SetCrossmatchResultsRequest) -> SetCrossmatchResultsResponse:
+    def set_crossmatch_results(self, r: SetCrossmatchResultsRequest) -> SetCrossmatchResultsResponse:
         pass

pyproject.toml

@@ -54,6 +54,9 @@ test = [
     "testcontainers-postgres>=0.0.1rc1",
 ]
 
+[tool.uv]
+config-settings = { editable_mode = "compat" }
+
 [tool.pytest.ini_options]
 pythonpath = ["."]
 addopts = "-W ignore::DeprecationWarning"
@@ -100,7 +103,36 @@ select = [
 
 [tool.basedpyright]
 typeCheckingMode = "off"
+venvPath = "."
+venv = ".venv"
+
+### warns
+reportDeprecated = "warning"
+reportIncompatibleMethodOverride = "warning"
+
+### pyright issues
+reportGeneralTypeIssues = "error"
+reportFunctionMemberAccess = "error"
+reportMissingImports = "error"
+reportMissingModuleSource = "error"
+reportInvalidTypeForm = "error"
+reportUnusedImport = "error"
+reportUnusedClass = "error"
+reportUnusedFunction = "error"
+reportUnusedVariable = "error"
+reportDuplicateImport = "error"
+reportWildcardImportFromLibrary = "error"
+reportAbstractUsage = "error"
+reportAssertTypeFailure = "error"
+reportCallIssue = "error"
+reportInconsistentOverload = "error"
+reportIndexIssue = "error"
+reportInvalidTypeArguments = "error"
+reportNoOverloadImplementation = "error"
+reportRedeclaration = "error"
+reportConstantRedefinition = "error"
 
+### based pyright issues
 reportUnreachable = "error"
 reportIgnoreCommentWithoutRule = "error"
 reportImplicitRelativeImport = "error"

tests/integration/create_table_test.py

@@ -32,7 +32,7 @@ def test_create_table(self):
             presentation.CreateSourceRequest(title="title", authors=["author"], year=2022)
         ).code
 
-        response, created = self.upload_manager.create_table(
+        self.upload_manager.create_table(
             presentation.CreateTableRequest(
                 table_name="table_name",
                 columns=[
@@ -61,7 +61,7 @@ def test_create_table_with_patch(self):
         ).code
         table_name = "table_name"
 
-        response, created = self.upload_manager.create_table(
+        _, created = self.upload_manager.create_table(
             presentation.CreateTableRequest(
                 table_name=table_name,
                 columns=[

tests/integration/rawdata_table_test.py

@@ -42,7 +42,7 @@ def test_create_table_happy_case(self):
             ],
         )
 
-        table_resp, _ = self.manager.create_table(
+        self.manager.create_table(
             presentation.CreateTableRequest(
                 table_name="test_table",
                 columns=[
@@ -90,7 +90,7 @@ def test_create_table_with_nulls(self):
             ],
         )
 
-        table_resp, _ = self.manager.create_table(
+        self.manager.create_table(
             presentation.CreateTableRequest(
                 table_name="test_table",
                 columns=[
@@ -171,7 +171,7 @@ def test_add_data_to_unknown_column(self):
             ],
         )
 
-        table_resp, _ = self.manager.create_table(
+        self.manager.create_table(
             presentation.CreateTableRequest(
                 table_name="test_table",
                 columns=[

tests/unit/data/layer0_repository_test.py

@@ -54,7 +54,7 @@ def setUp(self) -> None:
     def test_fetch_raw_data(self, _: str, kwargs: dict, expected_query: str):
         lib.returns(self.storage_mock.query, {"haha": [1, 2]})
 
-        _ = self.repo.fetch_raw_data("ironman", **kwargs)
+        self.repo.fetch_raw_data("ironman", **kwargs)
         args, _ = self.storage_mock.query.call_args
 
         actual = normalize_query(args[0])

tests/unit/domain/table_upload_test.py

@@ -131,7 +131,7 @@ def test_create_table(
 
         if err_substr is not None:
             with self.assertRaises(errors.RuleValidationError) as err:
-                _, _ = self.manager.create_table(request)
+                self.manager.create_table(request)
 
             self.assertIn(err_substr, err.exception.message())
         else:
@@ -251,7 +251,7 @@ def test_mapping(
     ):
         if err_substr:
             with self.assertRaises(errors.RuleValidationError) as err:
-                _ = domain_descriptions_to_data(input_columns)
+                domain_descriptions_to_data(input_columns)
 
             self.assertIn(err_substr, err.exception.message())
         else:

tests/unit/lib/astronomy_test.py

@@ -113,7 +113,7 @@ def test_apex_velocity(
     )
     def test_apex_velocity_with_uncertainties(
         self,
-        _: str, # test name
+        _: str,
         vel,
         lon,
         lat,