fix: use the correct property (http://cyberneko.org/html/properties/names/attrs) in case of the error handling for strange attributes

rbri · rbri · commit 4817dc829ef7 · 2026-03-08T14:47:14.000+01:00
diff --git a/src/main/java/org/htmlunit/cyberneko/HTMLScanner.java b/src/main/java/org/htmlunit/cyberneko/HTMLScanner.java
@@ -3217,8 +3217,7 @@ protected int scanAttribute(final XMLAttributesImpl attributes, final boolean[]
                     empty[0] = fCurrentEntity.skipMarkup(false);
                     return SCAN_FALSE;
                 }
-                // TODO add test and maybe fix me by using fNamesAttrs as second param
-                aname = '=' + scanName(false, fNamesElems);
+                aname = '=' + scanName(false, fNamesAttrs);
             }
             if (fReportErrors_ && !skippedSpaces) {
                 fErrorReporter.reportError("HTML1013", new Object[] {aname});
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html
@@ -0,0 +1 @@
+<input name='button' ='abc' value="detect me">
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical
@@ -0,0 +1,11 @@
+(html
+(head
+)head
+(body
+(input
+ANAME button
+A='ABC' 
+AVALUE detect me
+)input
+)body
+)html
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-dom b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-dom
@@ -0,0 +1,11 @@
+(html
+(head
+)head
+(body
+(input
+A='ABC' 
+ANAME button
+AVALUE detect me
+)input
+)body
+)html
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-frg b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-frg
@@ -0,0 +1,5 @@
+(input
+A='ABC' 
+ANAME button
+AVALUE detect me
+)input
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-html b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-html
@@ -0,0 +1 @@
+<html><head></head><body><input NAME="button" ='ABC'="" VALUE="detect me" /></body></html>
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-xni b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.canonical-xni
@@ -0,0 +1,11 @@
+startDocument [(1,1,0) (1,1,0) false]
+startElement (localpart="html",rawname="html",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+startElement (localpart="head",rawname="head",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endElement (localpart="head",rawname="head",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+startElement (localpart="body",rawname="body",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+emptyElement (localpart="input",rawname="input") [(1,1,0) (1,47,46) false]
+characters '
+'[(1,47,46) (2,1,47) false]
+endElement (localpart="body",rawname="body",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endElement (localpart="html",rawname="html",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endDocument [(2,1,47) (2,1,47) false]
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.settings b/src/test/resources/org/htmlunit/cyberneko/testfiles/error-handling/test-broken-attribute5.html.settings
@@ -0,0 +1 @@
+property http://cyberneko.org/html/properties/names/attrs upper

Original file line number	Diff line number	Diff line change
`@@ -3217,8 +3217,7 @@ protected int scanAttribute(final XMLAttributesImpl attributes, final boolean[]`
`3217`	`3217`	`empty[0] = fCurrentEntity.skipMarkup(false);`
`3218`	`3218`	`return SCAN_FALSE;`
`3219`	`3219`	`}`
`3220`		`- // TODO add test and maybe fix me by using fNamesAttrs as second param`
`3221`		`- aname = '=' + scanName(false, fNamesElems);`
	`3220`	`+ aname = '=' + scanName(false, fNamesAttrs);`
`3222`	`3221`	`}`
`3223`	`3222`	`if (fReportErrors_ && !skippedSpaces) {`
`3224`	`3223`	`fErrorReporter.reportError("HTML1013", new Object[] {aname});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<input name='button' ='abc' value="detect me">`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,11 @@ @@
 +(html
 +(head
 +)head
 +(body
 +(input
 +ANAME button
 +A='ABC'
 +AVALUE detect me
 +)input
 +)body
 +)html
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<html><head></head><body><input NAME="button" ='ABC'="" VALUE="detect me" /></body></html>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+property http://cyberneko.org/html/properties/names/attrs upper`