From 479f73e7050d3d579c8c9d8c8d4d9c4fb157b7ac Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 2 Jun 2026 14:46:41 +0000
Subject: [PATCH] ci: remove redundant terraform-validate and tflint workflows
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Both workflows are fully subsumed by ci.yml — same 20-module matrix,
same fmt/validate/tflint checks — but use older tool versions (Terraform
1.9.5 vs 1.9.8, tflint v0.53.0 vs v0.55.0) and unpinned action refs
(actions/checkout@v4 instead of the SHA-pinned form in ci.yml).

Every PR was generating ~40 duplicate check statuses and burning extra
runner minutes on redundant jobs. Delete both files and add .tflint.hcl
to ci.yml's path triggers to preserve the intent that a lint-config
change re-runs tflint.

https://claude.ai/code/session_01EkHbmuzhSkPQFNreTrmN6k
---
 .github/workflows/ci.yml                 |  2 +
 .github/workflows/terraform-validate.yml | 58 ------------------------
 .github/workflows/tflint.yml             | 58 ------------------------
 3 files changed, 2 insertions(+), 116 deletions(-)
 delete mode 100644 .github/workflows/terraform-validate.yml
 delete mode 100644 .github/workflows/tflint.yml

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index df897cd..3ea957a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -14,11 +14,13 @@ on:
   pull_request:
     paths:
       - 'modules/**'
+      - '.tflint.hcl'
       - '.github/workflows/ci.yml'
   push:
     branches: [main]
     paths:
       - 'modules/**'
+      - '.tflint.hcl'
       - '.github/workflows/ci.yml'
 
 permissions:
diff --git a/.github/workflows/terraform-validate.yml b/.github/workflows/terraform-validate.yml
deleted file mode 100644
index abc8de2..0000000
--- a/.github/workflows/terraform-validate.yml
+++ /dev/null
@@ -1,58 +0,0 @@
-name: terraform-validate
-
-on:
-  pull_request:
-    paths:
-      - 'modules/**'
-      - '.github/workflows/terraform-validate.yml'
-  push:
-    branches: [main]
-
-permissions:
-  contents: read
-
-jobs:
-  validate:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        module:
-          # Internal tier modules (one implementation per tier x cloud)
-          - modules/single-vm/aws
-          - modules/single-vm/azure
-          - modules/ha-hot-hot/aws
-          - modules/ha-hot-hot/azure
-          - modules/unlimited-scale/aws
-          - modules/unlimited-scale/azure
-          # Product-first wrapper modules (the public API)
-          - modules/asm-aws-single
-          - modules/asm-aws-ha
-          - modules/asm-aws-autoscale
-          - modules/asm-azure-single
-          - modules/asm-azure-ha
-          - modules/asm-azure-autoscale
-          - modules/sat-aws-single
-          - modules/sat-aws-ha
-          - modules/sat-aws-autoscale
-          - modules/sat-azure-single
-          - modules/sat-azure-ha
-          - modules/sat-azure-autoscale
-          # Supporting modules
-          - modules/network/aws
-          - modules/network/azure
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: hashicorp/setup-terraform@v3
-        with:
-          terraform_version: 1.9.5
-
-      - name: terraform fmt
-        run: terraform -chdir=${{ matrix.module }} fmt -check -recursive
-
-      - name: terraform init -backend=false
-        run: terraform -chdir=${{ matrix.module }} init -backend=false
-
-      - name: terraform validate
-        run: terraform -chdir=${{ matrix.module }} validate
diff --git a/.github/workflows/tflint.yml b/.github/workflows/tflint.yml
deleted file mode 100644
index eacf125..0000000
--- a/.github/workflows/tflint.yml
+++ /dev/null
@@ -1,58 +0,0 @@
-name: tflint
-
-on:
-  pull_request:
-    paths:
-      - 'modules/**'
-      - '.tflint.hcl'
-      - '.github/workflows/tflint.yml'
-  push:
-    branches: [main]
-
-permissions:
-  contents: read
-
-jobs:
-  tflint:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        module:
-          # Internal tier modules
-          - modules/single-vm/aws
-          - modules/single-vm/azure
-          - modules/ha-hot-hot/aws
-          - modules/ha-hot-hot/azure
-          - modules/unlimited-scale/aws
-          - modules/unlimited-scale/azure
-          # Product-first wrappers
-          - modules/asm-aws-single
-          - modules/asm-aws-ha
-          - modules/asm-aws-autoscale
-          - modules/asm-azure-single
-          - modules/asm-azure-ha
-          - modules/asm-azure-autoscale
-          - modules/sat-aws-single
-          - modules/sat-aws-ha
-          - modules/sat-aws-autoscale
-          - modules/sat-azure-single
-          - modules/sat-azure-ha
-          - modules/sat-azure-autoscale
-          # Supporting
-          - modules/network/aws
-          - modules/network/azure
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: terraform-linters/setup-tflint@v4
-        with:
-          tflint_version: v0.53.0
-
-      - name: tflint --init
-        run: tflint --init
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: tflint
-        run: tflint --chdir=${{ matrix.module }} --recursive --format=compact